Fix improper handling of msg.results in chunk callbacks (#964)

[jongwoo328]

Fix #964.

The delete msg.results; statement was likely introduced for memory optimization.
However, this caused the results to not be correctly passed as a parameter to complete when a chunk callback was present.

To address this, the release point of msg.results has been adjusted to ensure that results are properly passed to complete in cases where a chunk callback is used.

[pokoli]

Thanks for submiting the PR.

Do you think it should be easy to have a test suite which tests that the chunk Callback gets proper results? It will be great to include such test to prevent any regresion on the future.

[pokoli]

Could you elaborate why wee need to terminate the worker only when a function is defined?

[jongwoo328]

I think I may have unintentionally changed the original flow while modifying the code. I'll revert back to. Thank you.

[jongwoo328]

Sure.

Should I add test to the node_test.js and CUSTOM_TEST in test-cases.js?

[pokoli]

Should I add test to the node_test.js and CUSTOM_TEST in test-cases.js?
test-cases.js sounds like the right path for such test.

I will wait for your test before merging this.

[jongwoo328]

I've addressed my mistakes and adding tests.
Please let me know if there's anything else that needs to be adjusted.
Thank you for your guidance!

[pokoli]

I've addressed my mistakes and adding tests. Please let me know if there's anything else that needs to be adjusted. Thank you for your guidance!

I've run the test and I see your new test is failing. Could you have a look and address it? TIA

[jongwoo328]

Previous fixes didn't work on node environments 😅.
When using ChunkStreamer in a node environment, the _completeResults value being passed to complete was being set to undefined if the user provided the chunk option (in parseChunk).
I added code to store the results in _completeResults before setting results to undefined so that result can be properly passed to complete even if the chunk option is given.

Now it passes all tests!

[jongwoo328]

Hi @pokoli
just checking in to see if there’s any feedback or updates on this PR. Let me know if I should adjust anything. Thanks!

[jongwoo328]

Hi @pokoli
Could you please take another look when you have a moment?