Skip to content

Conversation

dboskovic
Copy link
Collaborator

Attempting to replicate #1098

@dboskovic dboskovic marked this pull request as draft August 5, 2025 03:03
@dboskovic dboskovic changed the title fix: replicating issue 1098 issue: replicating issue 1098 Aug 5, 2025
@cjrobbertse-ob
Copy link

cjrobbertse-ob commented Aug 11, 2025

Tests look good for #1098.

However, my tests 2 and 3 don't crash, but don't work as expected.

Test Case 2 Output:

Test Case 2: Renaming headers and ignoring unmapped (returning null) - BROKEN
------------------------------------------------------------------------------
  Transforming "Code Set" to "codeSet"
  Transforming "Code Name" to "codeName"
  Transforming "Code Value" to "codeValue"
  Returning null for header "description"
  Returning null for header "extra_column1"
  Returning null for header "extra_column2"
Duplicate headers found and renamed.
  Returning null for header "codeSet"
  Returning null for header "codeName"
  Returning null for header "codeValue"
  Returning null for header "null"
  Returning null for header "null_1"
  Returning null for header "null_2"

Parsed data (first row):
{
  "null": "Extra Data 2"
}

Total rows parsed: 3

Test Case 3 Output:

Test Case 3: Using array of headers without renaming - TESTING
---------------------------------------------------------------
  Keeping header "Code Set"
  Keeping header "Code Name"
  Keeping header "Code Value"
  Returning null for header "description"
  Returning null for header "extra_column1"
  Returning null for header "extra_column2"
Duplicate headers found and renamed.
  Keeping header "Code Set"
  Keeping header "Code Name"
  Keeping header "Code Value"
  Returning null for header "null"
  Returning null for header "null_1"
  Returning null for header "null_2"

Parsed data (first row):
{
  "Code Set": "CS001",
  "Code Name": "Test Code",
  "Code Value": "TC123",
  "null": "Extra Data 2"
}

Total rows parsed: 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants