Method Illuminate\Database\Eloquent\Collection::delete does not exist

[TantonFirst]

Method Illuminate\Database\Eloquent\Collection::delete does not exist at /var/www/vendor/dyrynda/laravel-cascade-soft-deletes/src/CascadeSoftDeletes.php(69)

Version: 4.4.1
$fetchMethod = 'chunk';
relation HasMany

[michaeldyrynda]

There's not a lot to go by in your issue description, but are you able to provide a minimum reproducible repo to better demonstrate the issue?

[danharper83]

Hi,

I'm getting the same issue but only when using chunk. I'm performing the initial delete with a filamentphp bulk action.

laravel/framework v11.43.0
filament/filament v3.2.135

Cheers Dan

[michaeldyrynda]

Hey @danharper83 - as above, are you able to provide a minimum reproducible repo to work with?

Sounds like in a chunk context, the cascading delete isn't called on a discrete model, but rather the whole collection, so the error makes sense in that regard.

[patrickcarlohickman]

PR #74 added in the chunk functionality. The issue is that when you use the chunk functionality, the callback being passed into the chunk() method was only designed to expect a model instance, not a Collection of models. So, the callback is accidentally calling delete() on the Collection.

Relevant code:

    protected function cascadeSoftDeletes($relationship)
    {
        $delete = $this->forceDeleting ? 'forceDelete' : 'delete';

        $cb = function($model) use ($delete) {
            isset($model->pivot) ? $model->pivot->{$delete}() : $model->{$delete}();
        };

        $this->handleRecords($relationship, $cb);
    }

    private function handleRecords($relationship, $cb)
    {
        $fetchMethod = $this->fetchMethod ?? 'get';

        if ($fetchMethod == 'chunk') {
            // $cb called here gets the Collection
            $this->{$relationship}()->chunk($this->chunkSize ?? 500, $cb);
        } else {
            foreach($this->{$relationship}()->$fetchMethod() as $model) {
                // $cb called here gets the model instance
                $cb($model);
            }
        }
    }