-
Notifications
You must be signed in to change notification settings - Fork 493
Twitter link #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Twitter link #47
Conversation
Update README with comprehensive setup guide and tutorial
Fixed pricing to say /yr instead of /mo for yearly plan pricing
@sumanthpabbati is attempting to deploy a commit to the Ras Mic Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThis update adds a new pricing card section within the Changes
Sequence Diagram(s)sequenceDiagram
participant UserInterface
participant PricingCard
UserInterface->>PricingCard: Render pricing cards
PricingCard->>PricingCard: Check `exclusive` flag
alt exclusive is true
PricingCard->>PricingCard: Apply exclusive styling
else exclusive is false
PricingCard->>PricingCard: Apply default styling
end
PricingCard->>PricingCard: Determine isYearly flag
alt isYearly is true
PricingCard->>PricingCard: Display price with "/yr"
else isYearly is false
PricingCard->>PricingCard: Display price with "/mo"
end
PricingCard->>UserInterface: Render benefits list below price
Possibly related PRs
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
components/homepage/pricing.tsxOops! Something went wrong! :( ESLint: 9.22.0 ESLint couldn't find an eslint.config.(js|mjs|cjs) file. From ESLint v9.0.0, the default configuration file is now eslint.config.js. https://eslint.org/docs/latest/use/configure/migration-guide If you still have problems after following the migration guide, please stop by ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🔭 Outside diff range comments (1)
components/homepage/pricing.tsx (1)
175-213
: 🛠️ Refactor suggestionStructure issue: Benefits list is not properly integrated
The benefits list (lines 205-212) appears disconnected from the proper component structure due to the issues in the newly added card section. It should be part of the main card content or properly nested within the new section.
I recommend restructuring this section to ensure the benefits list is properly integrated:
<CardContent className="space-y-6"> <div className="flex items-baseline gap-2"> <span className="text-5xl font-bold tracking-tight"> {currency === 'USD' ? '$' : currency} {priceAmount} </span> <span className="text-lg text-muted-foreground">/{interval}</span> </div> + <div className="space-y-3"> + {benefits.map((benefit, index) => ( + <div key={index} className="flex items-center gap-2"> + <CheckCircle2 className="h-5 w-5 flex-shrink-0 text-blue-500" /> + <p className="text-sm text-muted-foreground">{benefit.description}</p> + </div> + ))} + </div> </CardContent>Remove the additional card section or implement it properly with all required variables and correct structure.
🧰 Tools
🪛 Biome (1.9.4)
[error] 176-176: Expected corresponding JSX closing tag for 'div'.
Opening tag
closing tag
(parse)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
components/homepage/pricing.tsx
(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
components/homepage/pricing.tsx (1)
components/ui/card.tsx (4)
CardHeader
(79-79)CardTitle
(79-79)CardDescription
(79-79)CardContent
(79-79)
🪛 Biome (1.9.4)
components/homepage/pricing.tsx
[error] 174-174: Unexpected token. Did you mean {'}'}
or }
?
(parse)
[error] 176-176: Expected corresponding JSX closing tag for 'div'.
Opening tag
closing tag
(parse)
@@ -171,7 +171,37 @@ const PricingCard = ({ | |||
</span> | |||
<span className="text-lg text-muted-foreground">/{interval}</span> | |||
</div> | |||
)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix syntax error: Unmatched closing parenthesis
There appears to be a misplaced or unmatched closing parenthesis and bracket )}
that doesn't correspond to any opening statement. This will cause a syntax error and prevent the component from rendering properly.
This syntax error is likely related to the closing of the div
element in the previous section. The correct structure should maintain proper JSX nesting.
🧰 Tools
🪛 Biome (1.9.4)
[error] 174-174: Unexpected token. Did you mean {'}'}
or }
?
(parse)
<div> | ||
<CardHeader className="space-y-2 pb-4"> | ||
<CardTitle className="text-xl">{title}</CardTitle> | ||
<CardDescription | ||
className={cn("", { | ||
"text-gray-300": exclusive, | ||
})} | ||
> | ||
{description} | ||
</CardDescription> | ||
</CardHeader> | ||
|
||
<CardContent className="pb-4"> | ||
<div className="flex items-baseline gap-1"> | ||
<span | ||
className={cn("text-4xl font-bold", { | ||
"text-white": exclusive, | ||
})} | ||
> | ||
${isYearly ? yearlyPrice : monthlyPrice} | ||
</span> | ||
<span | ||
className={cn("text-muted-foreground", { | ||
"text-gray-300": exclusive, | ||
})} | ||
> | ||
{isYearly ? "/yr" : "/mo"} | ||
</span> | ||
</div> | ||
<div className="space-y-3"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix several critical issues in the new card section
The newly added card section has multiple critical issues:
- Several undefined variables:
title
,exclusive
,cn
,yearlyPrice
, andmonthlyPrice
- Missing closing tag for the
div
element started on line 176 - The
cn()
utility function is used but not imported
This code looks like it was incompletely merged or copied from another component. To fix these issues:
+ import { cn } from "@/lib/utils"; // Add this import at the top
// Then in the PricingCard component, add these missing variables
+ const title = name; // Or define an appropriate title
+ const exclusive = false; // Or define based on your business logic
+ const yearlyPrice = isYearly ? priceAmount : '0';
+ const monthlyPrice = !isYearly ? priceAmount : '0';
// Fix the structure of the card content section
<CardContent className="space-y-6">
<div className="flex items-baseline gap-2">
<span className="text-5xl font-bold tracking-tight">
{currency === 'USD' ? '$' : currency} {priceAmount}
</span>
<span className="text-lg text-muted-foreground">/{interval}</span>
</div>
- )}
-
- <div>
+ {/* Optional additional card section - uncomment and fix if needed */}
+ {/* <div>
<CardHeader className="space-y-2 pb-4">
<CardTitle className="text-xl">{title}</CardTitle>
<CardDescription
className={cn("", {
"text-gray-300": exclusive,
})}
>
{description}
</CardDescription>
</CardHeader>
<CardContent className="pb-4">
<div className="flex items-baseline gap-1">
<span
className={cn("text-4xl font-bold", {
"text-white": exclusive,
})}
>
${isYearly ? yearlyPrice : monthlyPrice}
</span>
<span
className={cn("text-muted-foreground", {
"text-gray-300": exclusive,
})}
>
{isYearly ? "/yr" : "/mo"}
</span>
</div>
+ </div> */}
Committable suggestion skipped: line range outside the PR's diff.
🧰 Tools
🪛 Biome (1.9.4)
[error] 176-176: Expected corresponding JSX closing tag for 'div'.
Opening tag
closing tag
(parse)
#46
solve this
Summary by CodeRabbit
New Features
Documentation