updated interleaver script and interleaved Database example #2537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the interleave_yaml script to detect and resolve duplicate item IDs during interleaving and updates the Makefile to use the new interleaved file name.
- Introduces an
increment_idhelper for generating unique IDs - Adds duplicate ID tracking, automatic resolution, and reporting in
process_yaml - Updates Makefile target from
Database-interleaved-new.yamltoDatabase-interleaved.yaml
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/scripts/interleave_yaml.py | Added increment_id, duplicate ID detection/resolution logic, and reporting |
| project.Makefile | Updated the interleaved YAML target filename |
Comments suppressed due to low confidence (1)
src/scripts/interleave_yaml.py:105
- Consider adding unit tests for the duplicate ID resolution logic and the
increment_idfunction to ensure edge cases (e.g., '9'→'10', 'z'→'za') are handled correctly.
# Check for duplicate IDs within this slot and resolve them
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to determine when the script would be run and what benefit we get, when the content of the individual
src/data/valid/Database*.yamlfiles will all be checked bylinkml-run-examplesanywayIt does provide one fiel that can serve as a mock database