Skip to content

Add a /product path for microg.xml search path to comply with strict build requirements #2852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karlbaumg opened this issue Apr 7, 2025 · 3 comments

Comments

@karlbaumg
Copy link

karlbaumg commented Apr 7, 2025

Is your feature request related to a problem? Please describe.

In LineageOS, and other distributions relying on lineageos4microg project to include microG, we are having issues with using a /system-based path to find the microg.xml in builds that are marked as strict which doesn't let system partition to have much additions, see lineageos4microg/android_vendor_partner_gms#44

However, in microG, putting a /system/etc/microg.xml is the only way to provide build-time default settings.

Describe the solution you'd like

Another path such as /product/etc/microg.xml can be added such that microG checks that first and if it doesn't exist, then fall back to /system/etc/microg.xml so that no existing builds break and we can switch to /product/etc/microg.xml in future builds.

Describe alternatives you've considered

We tried to add it as exception but it doesn't work in strict builds lineageos4microg/android_vendor_partner_gms#46

@petefoth
Copy link

petefoth commented Apr 7, 2025

Describe the solution you'd like

Another path such as /vendor/etc/microg.xml can be added such that microG checks that first and if it doesn't exist, then fall back to /system/etc/microg.xml so that no existing builds break and we can switch to /vendor/etc/microg.xml in future builds.

At the moment, los4microg puts the file in /product/etc/, so having GmsCore look there before falling back to /system/etc would be best for us 😄

@steadfasterX
Copy link

.. and for me system_ext/etc/ would be the best place ;)
according to https://source.android.com/docs/core/architecture/partitions/product-interfaces#about-the-artifact-path-requirements system_ext or product are the correct placements for this these days so it would be great to have the choice even (if possible).

@ale5000-git
Copy link
Member

ale5000-git commented Apr 8, 2025

I think, if possible, it would be best if it first search on the same partition of the apk (whatever it is) and then fallback to system.
It would be rather strange to have it in a partition different from the apk.

@karlbaumg karlbaumg changed the title Add a /vendor path for microg.xml search path to comply with strict build requirements Add a /product path for microg.xml search path to comply with strict build requirements Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants