Skip to content

Fix Consors bank app crash #3263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nathan9513-aps wants to merge 4 commits into from
+13 −1
Closed

Fix Consors bank app crash #3263

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c8fbc0
fix: improve error handling in getSignedInAccountFromIntent method
nathan9513-aps Feb 2, 2026
b894813
fix: add missing Status import for GoogleSignIn class
nathan9513-aps Feb 2, 2026
2c9d4a4
fix: handle null GoogleSignInResult in getSignedInAccountFromIntent
nathan9513-aps Feb 2, 2026
0c10b50
Merge pull request #4 from nathan9513-aps/corsor_bank_wip
nathan9513-aps Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion play-services-auth/src/main/java/com/google/android/gms/auth/api/signin/GoogleSignIn.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
import com.google.android.gms.auth.api.signin.internal.Storage;
import com.google.android.gms.common.api.ApiException;
import com.google.android.gms.common.api.Scope;
import com.google.android.gms.common.api.Status;
import com.google.android.gms.tasks.Task;
import com.google.android.gms.tasks.Tasks;
import org.microg.gms.auth.api.signin.GoogleSignInCommon;
Expand Down Expand Up @@ -106,8 +107,19 @@ public static GoogleSignInAccount getLastSignedInAccount(@NonNull Context contex
@NonNull
public static Task<GoogleSignInAccount> getSignedInAccountFromIntent(@Nullable Intent data) {
GoogleSignInResult signInResultFromIntent = GoogleSignInCommon.getSignInResultFromIntent(data);
if (signInResultFromIntent == null) {
return Tasks.forException(new ApiException(Status.INTERNAL_ERROR));
}
GoogleSignInAccount signInAccount = signInResultFromIntent.getSignInAccount();
return (!signInResultFromIntent.isSuccess() || signInAccount == null) ? Tasks.forException(new ApiException(signInResultFromIntent.getStatus())) : Tasks.forResult(signInAccount);
Status status = signInResultFromIntent.getStatus();
if (!signInResultFromIntent.isSuccess() || signInAccount == null) {
if (status == null) {
return Tasks.forException(new ApiException(Status.INTERNAL_ERROR));
} else {
return Tasks.forException(new ApiException(status));
}
}
return Tasks.forResult(signInAccount);
}

/**
Expand Down