Skip to content

Commit 3f6cec6

Browse files
srinaathSrinaath Ravichandran
and
Srinaath Ravichandran
authored
Add id for conversation object (#2129)
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com> Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com>
1 parent 45d7cf1 commit 3f6cec6

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

packages/app/main/src/server/routes/channel/conversations/handlers/createConversation.spec.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ import { createCreateConversationHandler } from './createConversation';
3838
describe('createConversation handler', () => {
3939
it('should send a 201 with a create conversation response when the conversation does not exist', () => {
4040
const mockNewConversation = {
41+
id: 'convo1',
4142
conversationId: 'convo1',
4243
members: [],
4344
normalize: jest.fn(),
@@ -75,6 +76,7 @@ describe('createConversation handler', () => {
7576
conversationId: mockNewConversation.conversationId,
7677
endpointId: req.botEndpoint.id,
7778
members: mockNewConversation.members,
79+
id: mockNewConversation.conversationId,
7880
});
7981
expect(res.end).toHaveBeenCalled();
8082
expect(next).toHaveBeenCalled();

packages/app/main/src/server/routes/channel/conversations/handlers/createConversation.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ export function createCreateConversationHandler(emulatorServer: EmulatorRestServ
7474
conversationId: conversation.conversationId,
7575
endpointId: botEndpoint.id,
7676
members: conversation.members,
77+
id: conversation.conversationId,
7778
});
7879
res.end();
7980
next();

0 commit comments

Comments
 (0)