-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Open
Labels
area-accessibilitybacklogOut of scope for the current iteration but it will be evaluated in a future release.Out of scope for the current iteration but it will be evaluated in a future release.bugIndicates an unexpected problem or an unintended behavior.Indicates an unexpected problem or an unintended behavior.
Milestone
Description
Screenshots
When typing markdown
, the external link icon shows up.
When typing card markdown
, the external link icon did not show up.
Version
4.13.0
Describe the bug
The new "external link icon" only works with the command markdown
, but not the card markdown
command.
Steps to reproduce
- Go to https://compulim.github.io/webchat-loader/
- Type
card markdown
Expected behavior
The links in the Adaptive Cards should show an external link icon.
Additional context
This is because the CSS class name was not applied to the content of Adaptive Cards, but only the TextContent.js
.
Action items
- Update the
Styles/StyleSet/AdaptiveCardRenderer.ts
and use the external link icon, as like inStyles/StyleSet/TextContent.ts
- Make sure our existing test cover the external link icon, otherwise, add new tests
[Bug]
Metadata
Metadata
Assignees
Labels
area-accessibilitybacklogOut of scope for the current iteration but it will be evaluated in a future release.Out of scope for the current iteration but it will be evaluated in a future release.bugIndicates an unexpected problem or an unintended behavior.Indicates an unexpected problem or an unintended behavior.