Skip to content

feat: grouping refine part 2 #5590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Oct 1, 2025
Merged

feat: grouping refine part 2 #5590

merged 23 commits into from
Oct 1, 2025

Conversation

OEvgeny
Copy link
Collaborator

@OEvgeny OEvgeny commented Sep 22, 2025 •
edited
Loading

Changelog Entry

  • Added visual message grouping following the isPartOf property of the Message entity, in PR #5553, in PR #5585, in PR #5590, by @OEvgeny

Description

This is further refinement of the part grouping work. Focused mostly on:

  • bringing support of message status to the regular activities
  • adding keyboard navigation tests
  • minor tweaks and polishing

Specific Changes

  • __tests__ have more tests for related aspects of UX
  • component has some improvements for Stacked Layout styles
  • fluent-theme has minor tweaks to make message status look nicer when not in the group

-

  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

This section is for contributors to review your work.

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

OEvgeny
OEvgeny commented Sep 24, 2025
View reviewed changes
OEvgeny and others added 12 commits September 29, 2025 23:36
@OEvgeny
test: add tests for keyboard collaps/expand
428c815
@OEvgeny
feat: support a11y for activity button
a8f52be
@OEvgeny
feat: cleanup and improve custom properties
53fd424
@OEvgeny
Add message status outside of group test
aa83ffd
@compulim @OEvgeny
Add support for <script type="module"> (a.k.a. fat module) (#5592)
7bc8e33 
* First attempt

* Clean up

* Ignore static

* Better separator

* Add importmap

* Add static

* Add version number

* Clean up

* Short chunk name

* Unify entryNames

* Use __ (double underscore)

* Add sourcemap

* Better React

* Clean up

* Add version number

* Save ReactDOM

* Use React CJS without global

* Add Speech SDK

* Repack

* Add base64-js

* Fix eslint

* Repack botframework-directlinejs

* Better esbuild src

* Repack react and react-dom

* Add sourcemap

* Repack react-is

* Clean up

* Add @types/*

* Clean up

* Delete object-assign

* Delete object-assign

* Cheaper object-assign

* Remove unnecessary devDependencies

* Clean up

* Add comment for 1.45.0

* Fix eslint

* Remove isConcurrentMode

* Bump to react-is@16

* Revert

* Add precommit

* Debump to 1.17.0

* Add repack

* Fix npm start for repacks

* Fix npm run build

* Add start:static

* Better message

* Better message

* Clean up

* Add first fat module test

* Add more tests

* Add more exports and tests

* Use isomorphic React

* Add snapshot

* Fix watch mode

* Isomorphic React as esbuild plugin

* Fix npm run build

* Remove isomorphic React

* Rename to skip

* Add to lint-staged

* Fix dev server

* Add npm start html-react-parser

* Remove comment

* Clean up

* Don't print token

* Add test for createRoot

* Fix import react-dom

* Add entry

* Add static

* Upload static artifact
@compulim @OEvgeny
Support <script type="module"> imports for Fluent skin pack (#5593)
a96270c 
* Add test

* Build /static

* Add react@18 and react-dom@18

* Add tests for fluent-theme

* Add tsx test

* No need object-assign aliasing

* Add comment

* Add entry
@compulim @OEvgeny
Print commit stats (#5596)
86ba85f 
* Add printCommitStats

* New doc category

* Better name

* Fix filename and run npm ci

* Add dependencies

* Better categorization

* Fetch main

* Diff from main

* Use origin/main

* Better output

* Add disclaimer

* Add a broader permissions.content: read
@compulim @OEvgeny
Reorganize /static through vendor chunks (#5595)
cb43a9c 
* Add react@18 and react-dom@18

* No need object-assign aliasing

* Exporting allowlisted packages only

* Remove unnecessary dependencies

* Remove async

* Auto exporting own packages

* Remove comments

* Remove unnecessary code

* Add doc

* Restructure

* Readability

* Readability

* Readability

* Readability

* Readability

* Readability

* More contents

* Clarification

* Add links

* Fix plugins

* Add middleware test for tsx

* Add esm.run

* Use named exports

* Add simple test

* Clean up

* Fix build

* Add React 18 tests

* Clean up

* 4.19.0

* Add reads

* Readability

* Wordings

* Add "Step X:"

* Code clarity

* New line

* Readability

* Add UMD

* Better UMD snippet

* Add snapshot

* Rename

* Rename plugin

* Readability

* Mark 16.8.6 as baseline

* Readability

* Fix react.18 filename

* ESM build for test harness and page object

* Move all fatModule test to use ESM harness and page-object

* Fix speech token

* Clean up

* Apply PR suggestions

* Fix test-to-code ratio
@compulim @OEvgeny
Add delay to --watch and better build validation (#5599)
d385e29 
* Add delay to --watch

* Add entry
@compulim @OEvgeny
Show deprecation for legacy imports (#5600)
36f4c1d 
* Show deprecation for old imports

* Add entry

* Update message

* Rename to deprecateObject

* Check for no dupe deprecation notes

* Get own properties only

* Add denylist

* Use warnOnce from base

* Add explicit type casting
@compulim @OEvgeny
Allow any ARIA role attribute/prop (#5601)
c566238 
* Allow any role

* Allow role of string

* Fix propTypes

* Remove obsoleted tests
@OEvgeny
Fix message status tests
55c7a6b
@OEvgeny OEvgeny force-pushed the feat/grouping-refine-2 branch from 1959860 to 55c7a6b Compare September 29, 2025 23:36
@OEvgeny OEvgeny marked this pull request as ready for review September 30, 2025 01:24
@OEvgeny OEvgeny changed the title Feat/grouping refine 2 feat: grouping refine part 2 Sep 30, 2025
@OEvgeny OEvgeny merged commit 29fde4f into main Oct 1, 2025
53 of 54 checks passed
@OEvgeny OEvgeny deleted the feat/grouping-refine-2 branch October 1, 2025 06:56
@OEvgeny OEvgeny mentioned this pull request Oct 1, 2025
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compulim compulim compulim approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

@beyackle2 beyackle2 Awaiting requested review from beyackle2 beyackle2 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OEvgeny @compulim