Add ability to provide a custom logger class to DiskANN index #661
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Briefly explain your changes.
DiskANN code output various statements to cout and cerr streams. In some cases this code runs as part of the service that cannot use these streams, such as when run as an Autopilot service. This output is crucial for monitoring, debugging.
The change adds an interface for the logging component and allows to specify a custom implementation of the logger. By default logging is done to a console implementation (similar to the existing cout and cerr).
Any other comments?
Mostly converted cout and cerr statements from index.cpp, but not everything. Only the most important parts were converted.