Wait index checkpoint phase should behave similarly to wait flush - perform create-new-record during a checkpoint if record is not in the new version (during the snapshot). (#724)

badrishc · web-flow · commit 65e379f31dac · 2022-07-18T14:44:04.000-07:00
diff --git a/cs/src/core/Index/FASTER/FASTERImpl.cs b/cs/src/core/Index/FASTER/FASTERImpl.cs
@@ -688,6 +688,7 @@ private LatchDestination AcquireLatchUpsert<Input, Output, Context>(FasterExecut
                         }
                         break; // Normal Processing
                     }
+                case Phase.WAIT_INDEX_CHECKPOINT:
                 case Phase.WAIT_FLUSH:
                     {
                         if (!CheckEntryVersionNew(logicalAddress))
@@ -1233,6 +1234,7 @@ private LatchDestination AcquireLatchRMW<Input, Output, Context>(PendingContext<
                         }
                         break; // Normal Processing
                     }
+                case Phase.WAIT_INDEX_CHECKPOINT:
                 case Phase.WAIT_FLUSH:
                     {
                         if (!CheckEntryVersionNew(logicalAddress))
@@ -1638,6 +1640,7 @@ internal OperationStatus InternalDelete<Input, Output, Context, FasterSession>(
                             }
                             break; // Normal Processing
                         }
+                    case Phase.WAIT_INDEX_CHECKPOINT:
                     case Phase.WAIT_FLUSH:
                         {
                             if (!CheckEntryVersionNew(logicalAddress))

Original file line number	Diff line number	Diff line change
`@@ -688,6 +688,7 @@ private LatchDestination AcquireLatchUpsert<Input, Output, Context>(FasterExecut`
`688`	`688`	`}`
`689`	`689`	`break; // Normal Processing`
`690`	`690`	`}`
	`691`	`+ case Phase.WAIT_INDEX_CHECKPOINT:`
`691`	`692`	`case Phase.WAIT_FLUSH:`
`692`	`693`	`{`
`693`	`694`	`if (!CheckEntryVersionNew(logicalAddress))`
`@@ -1233,6 +1234,7 @@ private LatchDestination AcquireLatchRMW<Input, Output, Context>(PendingContext<`
`1233`	`1234`	`}`
`1234`	`1235`	`break; // Normal Processing`
`1235`	`1236`	`}`
	`1237`	`+ case Phase.WAIT_INDEX_CHECKPOINT:`
`1236`	`1238`	`case Phase.WAIT_FLUSH:`
`1237`	`1239`	`{`
`1238`	`1240`	`if (!CheckEntryVersionNew(logicalAddress))`
`@@ -1638,6 +1640,7 @@ internal OperationStatus InternalDelete<Input, Output, Context, FasterSession>(`
`1638`	`1640`	`}`
`1639`	`1641`	`break; // Normal Processing`
`1640`	`1642`	`}`
	`1643`	`+ case Phase.WAIT_INDEX_CHECKPOINT:`
`1641`	`1644`	`case Phase.WAIT_FLUSH:`
`1642`	`1645`	`{`
`1643`	`1646`	`if (!CheckEntryVersionNew(logicalAddress))`