Remove parameter in createOdspCreateContainerRequest() in v2.40
#23882
Assignees
Labels
breaking change
This PR or issue would introduce a breaking change
Comments
MarioJGMsoft
added
the
breaking change
MarioJGMsoft
changed the title
createOdspCreateContainerRequest().containerPackageInfo in v2.40
MarioJGMsoft
changed the title
createOdspCreateContainerRequest().containerPackageInfo in v2.40createOdspCreateContainerRequest() in v2.40
MarioJGMsoft
changed the title
createOdspCreateContainerRequest() in v2.40createOdspCreateContainerRequest() in v2.40
MarioJGMsoft
changed the title
createOdspCreateContainerRequest() in v2.40createOdspCreateContainerRequest() in v2.40
jatgarg
added a commit
that referenced
this issue
Apr 14, 2025
…nerRequest` (#23919) ## Description As of PR #22849 (released in 2.23), preferred pattern to add "containerPackageName" parameter to request is via URL resolver instead of `createOdspCreateContainerRequest`'s last parameter. Tag calling `createOdspCreateContainerRequest` with that parameter as deprecated now, and then in the 2.40 release remove that form altogether. ## Future Breaking Changes See [issue 23882](#23882) for more details. ## Reviewer Guidance Please let me know if there's anything else I should be aware of or can do better, thanks! Fixes: [AB#31450](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/31450) --------- Co-authored-by: Jatin Garg <48029724+jatgarg@users.noreply.github.com>
|
@jatgarg, that PR did not have the removal - re-opening |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
containerPackageInfoparameter of thecreateOdspCreateContainerRequest()function will be deprecated and removed in 2.40. Please update your code accordingly to avoid any disruptions.Context
The parameter
containerPackageInfoincreateOdspCreateContainerRequest()makes it so that when a request is resolved, the appropriate information can be extracted from the request and stored. In version 2.23,OdspDriverUrlResolverForShareLinkconstructor takes optionalIContainerPackageInfothat will provide functionality more efficiently.Approach
This will mean that the name of the containerPackage can no longer be sent through the request. Instead, it can be added in the constructor of
OdspDriverUrlResolverForShareLink. Then it will be processed and added to the SharingLink when said resolver resolves a request.If using a custom resolver, update it to provide this capability similar to #23878.
Expected Timeline
To be removed in version 2.40.
The text was updated successfully, but these errors were encountered: