Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
container-runtime: Add API for default configuration #24422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
container-runtime: Add API for default configuration #24422
Changes from 11 commits
9741b43
0a00f9a
f5ca37e
90cf8c5
b3fc9b3
84b1168
6aee854
811f853
41b7e4f
8d20d4c
8323a4a
2211e2d
5ee0550
e25f7e5
7c37c57
2e1086d
c3ee030
2d9df35
2caeab3
07d86ef
81c8e8e
860c991
7690d0c
9652cd3
a2a8080
20b6844
c290f1e
7f8aff6
5791f81
dd81726
ec34789
82b8c55
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could restate this for an enduring comment. Why 1.0.0 and not another value?
I think we mean to capture the lowest version this runtime can be compatible with.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good callout, I’ll update the comment. As for why 1.0.0, our compatibility policy is to support N/N-1 (or N/N-2 with the correct configs), and N includes all minor versions of the current public major release. So in today's case, N/N-1 means all 2.x versions and 1.x versions, respectively.
I don't think it makes sense to allow lower than 1.0.0 because LTS starts at 1.4.0. We could set it to
"1.4.0"
to match LTS, but there’s no functional difference between the two (for compatibility purposes), and I personally prefer 1.0.0 to stay consistent with the broad "N includes all minor versions" reasoning above.