Skip to content

Make failProxy fail on unrecognized properties #24460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChumpChief merged 2 commits into from
Apr 28, 2025
Merged

Make failProxy fail on unrecognized properties #24460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c8b2de
Make failProxy fail on unrecognized properties
ChumpChief Apr 25, 2025
71defad
Use generic
ChumpChief Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/loader/container-loader/src/test/failProxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export const failSometimeProxy = <T extends object>(handler: Partial<T>): T => {
if (p in handler) {
return Reflect.get(t, p, r);
}
return failProxy();
throw new Error(`${p.toString()} not implemented`);
},
});
return proxy;
Expand Down
2 changes: 2 additions & 0 deletions packages/loader/container-loader/src/test/loader.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ const createCodeLoader = (props?: { createDetachedBlob?: boolean }): ICodeDetail
pending: [],
}),
ILayerCompatDetails: undefined,
disposed: false,
setConnectionState: () => {},
});
},
},
Expand Down
2 changes: 2 additions & 0 deletions packages/loader/container-loader/src/test/loaderLayerCompatValidation.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,8 @@ describe("Runtime Layer compatibility", () => {
pending: [],
}),
ILayerCompatDetails: compatibilityDetails,
disposed: false,
setConnectionState: () => {},
});
},
},
Expand Down
3 changes: 1 addition & 2 deletions packages/runtime/container-runtime/src/test/blobHandles.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@ export const failProxy = <T extends object>(handler: Partial<T> = {}): T => {
if (handler !== undefined && p in handler) {
return Reflect.get(t, p, r);
}
// eslint-disable-next-line @typescript-eslint/no-unsafe-return
return failProxy();
throw new Error(`${p.toString()} not implemented`);
},
});
return proxy;
Expand Down
7 changes: 5 additions & 2 deletions packages/runtime/container-runtime/src/test/blobManager.stashed.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ export const failProxy = <T extends object>(handler: Partial<T> = {}): T => {
if (handler !== undefined && p in handler) {
return Reflect.get(t, p, r);
}
// eslint-disable-next-line @typescript-eslint/no-unsafe-return
return failProxy();
throw new Error(`${p.toString()} not implemented`);
},
});
return proxy;
Expand All @@ -52,6 +51,10 @@ function createBlobManager(overrides?: Partial<ConstructorParameters<typeof Blob
blobManagerLoadInfo: {},
stashedBlobs: undefined,
localBlobIdGenerator: undefined,
storage: failProxy<IDocumentStorageService>(),
sendBlobAttachOp: () => {},
blobRequested: () => {},
isBlobDeleted: () => false,
createBlobPlaceholders: false,

// overrides
Expand Down
Loading