Remove closeAndGetPendingLocalState

[ChumpChief]

The purpose of closeAndGetPendingLocalState (as opposed to getPendingLocalState) is to trigger a special behavior of the BlobManager to fake blob upload completion, such that the customer then will store their handles to be included in the pending state. However, this flow is not needed with payload pending handles, which is the only flow we intend to support in combination with pending state going forward.

Removing this entry point to the special behavior frees us up to make simplifications in the runtime and BlobManager (to be done in a following PR). This should be a safe removal as it's an internal-only API with no current customers.

Internal uses of the API are primarily just converted to call getPendingLocalState followed by close(), except where the test is specifically for blob functionality. These will need to be updated after we add blob support to getPendingLocalState via payload pending handles.

AB#45000

[Copilot]

Pull Request Overview

This PR removes the closeAndGetPendingLocalState API method and replaces its usage with separate calls to getPendingLocalState() followed by close(). The removal simplifies the runtime by eliminating a special blob upload completion behavior that is no longer needed with the payload pending handles flow.

• Replaces all closeAndGetPendingLocalState() calls with getPendingLocalState() followed by close()
• Removes the closeAndGetPendingLocalState method from container interfaces and implementations
• Comments out blob-related tests that relied on the special behavior, to be updated later for payload pending handles

Reviewed Changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
packages/test/test-service-load/src/runner.ts	Updates offline container handling to use new API pattern
packages/test/test-end-to-end-tests/src/test/refreshSerializedStateManager.spec.ts	Replaces API calls in snapshot refresh tests
packages/test/test-end-to-end-tests/src/test/offline/waitForSummary.spec.ts	Updates summary waiting tests with new API pattern
packages/test/test-end-to-end-tests/src/test/offline/stashedOps.spec.ts	Converts stashed ops tests and comments out blob-specific tests
packages/test/test-end-to-end-tests/src/test/offline/blobHandles.spec.ts	Comments out blob test that relied on special behavior
packages/test/test-end-to-end-tests/src/test/migration-shim/reconnect.spec.ts	Updates migration tests to use new API pattern
packages/test/test-end-to-end-tests/src/test/intervalCollectionEndToEndTests.spec.ts	Replaces API call in interval collection test
packages/test/test-end-to-end-tests/src/test/data-virtualization/*.spec.ts	Updates data virtualization tests with new API pattern
packages/test/test-end-to-end-tests/src/test/container.spec.ts	Updates container test name and implementation
packages/runtime/container-runtime/src/containerRuntime.ts	Updates comment reference to new API method
packages/loader/container-loader/src/test/serializedStateManager.spec.ts	Removes props parameter from test calls
packages/loader/container-loader/src/serializedStateManager.ts	Simplifies method signature by removing props parameter
packages/loader/container-loader/src/container.ts	Removes deprecated method and interface definitions
packages/dds/tree/src/test/shared-tree/sharedTree.spec.ts	Updates tree tests to use new API pattern
experimental/dds/tree/src/test/utilities/TestUtilities.ts	Updates test utility to use new API pattern

[anthony-murphy]

i think these should stay

[ChumpChief]

sessionExpiryTimerStarted and snapshotSequenceNumber have never been passed here, even before this change. I was actually thinking about removing them outright rather than leaving them here and undefined, but wasn't sure what impact it'd have on telemetry.

[dannimad]

makes sense since both fields are encapsulated in the pending runtime state

[anthony-murphy]

can we skip, rather than comment it out, and there should be a bug linked to the skip

[ChumpChief]

Done in latest