-
Notifications
You must be signed in to change notification settings - Fork 397
fix: added e2e testing in validate non waf pipeline and fixed WAF deployment pipeline #604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roopan-Microsoft
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces several updates to the deployment workflows and supporting scripts to enhance model deployment flexibility, automate post-deployment tasks, and improve configuration handling. The main changes include parameterizing model capacities, updating model versions and names, adding post-deployment automation, and refining script logic for better robustness and clarity.
Deployment Workflow Enhancements
GPT_MIN_CAPACITY,O4_MINI_MIN_CAPACITY, andGPT41_MINI_MIN_CAPACITYin both.github/workflows/deploy.ymland.github/workflows/deploy-waf.yml, allowing for more flexible and environment-specific resource allocation. [1] [2] [3] [4] [5]gpt-4.1-miniwith version2025-04-14and set the default image tag tolatest_v3. [1] [2]Automation and Post-Deployment Tasks
deploy.ymlto automate uploading team configurations and processing sample data, improving deployment completeness and reducing manual intervention.e2e-test) that runs after a successful deployment and before cleanup, ensuring deployments are validated before resource teardown.Script and Logic Improvements
infra/scripts/checkquota.shto support new model capacity variables, clarified required and optional environment variables, and improved model capacity mapping logic. [1] [2] [3]infra/scripts/upload_team_config.pyto better handle empty or missing user principal IDs. [1] [2]Other Notable Updates
These changes collectively improve the reliability, flexibility, and automation of the deployment process.
Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information