Skip to content

Conversation

@Thanusree-Microsoft
Copy link
Contributor

@Thanusree-Microsoft Thanusree-Microsoft commented Nov 7, 2025

Purpose

This pull request introduces several improvements and updates to the deployment workflows, scripts, and documentation for the project. The most significant changes include enhancements to model capacity configuration, deployment workflow logic, post-deployment automation, and documentation for onboarding and usage. Below are the most important changes grouped by theme:

Deployment Workflow Updates:

  • Updated model capacity environment variables and values in .github/workflows/deploy.yml and .github/workflows/deploy-waf.yml to support multiple models (GPT_MIN_CAPACITY, O4_MINI_MIN_CAPACITY, GPT41_MINI_MIN_CAPACITY) and changed their default values for production and WAF deployments. [1] [2] [3] [4]
  • Modified deployment logic to use new model names and versions (gpt-4.1-mini with version 2025-04-14) and increased model capacity for deployments.
  • Changed the container app selection logic to ensure the correct backend app is chosen during deployment.
  • Updated image tags for non-hotfix branches to use latest_v3.

Post-Deployment Automation:

  • Added a post-deployment step to run scripts for uploading team configuration and processing sample data, improving initial environment setup.
  • Introduced an end-to-end test job (e2e-test) that runs automatically after a successful deployment and before resource cleanup.

Infrastructure Script Improvements:

  • Enhanced infra/scripts/checkquota.sh to support new model capacities, clarified required/optional environment variables, and improved region/model validation logic. [1] [2] [3]
  • Improved robustness of infra/scripts/upload_team_config.py by handling empty user principal IDs and request parameters more safely. [1] [2]

Documentation Enhancements:

  • Added a "Next Steps" section and linked to new sample questions in docs/DeploymentGuide.md to guide users after deployment.
  • Introduced docs/SampleQuestions.md with detailed sample workflows for Retail, Marketing, and HR teams to help users explore the solution.

Miscellaneous Updates:

  • Updated the accelerator name to "MACAE v3" in the test automation workflow for clarity.
  • Fixed backend path resolution in the interactive test harness to support the new directory structure.

These changes collectively improve deployment flexibility, automation, onboarding experience, and documentation for users and developers.

Does this introduce a breaking change?

  • Yes
  • No

Other Information

Added new page and reference link in DeploymentGuide.md.

Thanusree-Microsoft and others added 30 commits October 27, 2025 17:59
Created a new document for Sample questions
Added sample questions and scenarios for users to explore various functionalities in the app.
Updated sample prompts for various scenarios to enhance clarity and consistency.
Added a 'Next Steps' section with sample questions after deployment instructions.
fix: added e2e testing in validate non waf pipeline and fixed WAF deployment pipeline
Roopan-Microsoft and others added 9 commits November 4, 2025 06:33
Removed the instruction to provide a plan to increase satisfaction.
Updated instructions for team selection and scenarios, enhancing clarity and detail.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Updated response time notes and observations for various tasks in the Retail, Product Marketing, and HR Onboarding scenarios.
docs: Added Sample Questions page and reference file
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces significant updates to the Multi-Agent Custom Automation Engine solution, including model upgrades, improved deployment processes, enhanced documentation, and automated post-deployment configuration.

Key Changes:

  • Updates Azure OpenAI model configurations from gpt-4o to gpt-4.1-mini with new capacity settings
  • Adds automated post-deployment scripts for team configuration and sample data processing
  • Introduces comprehensive sample workflow documentation with scenario guides
  • Enhances quota checking to support multiple model types (o4-mini, gpt4.1, gpt4.1-mini)

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/tests/agents/interactive_test_harness/reasoning_agent_interactive.py Corrects backend path resolution by adding an additional parent directory level
infra/scripts/upload_team_config.py Adds validation to handle empty string user principal IDs and includes minor whitespace change
infra/scripts/checkquota.sh Updates quota checking to support three model types with configurable capacities
docs/images/samplequestion_1.png Adds new screenshot image for documentation (binary file)
docs/SampleQuestions.md Creates comprehensive workflow documentation with retail, marketing, and HR scenarios
docs/DeploymentGuide.md Adds "Next Steps" section linking to sample questions documentation
.github/workflows/test-automation.yml Updates accelerator name from "MACAE" to "MACAE v3"
.github/workflows/deploy.yml Updates model configurations, adds post-deployment scripts, integrates E2E testing, and modifies notification logic
.github/workflows/deploy-waf.yml Adds environment variables for multiple model capacity configurations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

CONTAINER_APP_NAME=$(az containerapp list \
--resource-group ${{ env.RESOURCE_GROUP_NAME }} \
--query "[0].name" -o tsv)
--query "[?starts_with(name, 'ca-') && !contains(name, 'mcp')].name" -o tsv)
Copy link

Copilot AI Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The query filter !contains(name, 'mcp') may not work correctly if there are container apps with names that don't follow expected naming patterns. Consider using a more specific filter based on the actual naming convention used in the bicep templates (e.g., checking for a specific prefix or suffix that uniquely identifies the backend container app).

Suggested change
--query "[?starts_with(name, 'ca-') && !contains(name, 'mcp')].name" -o tsv)
--query "[?starts_with(name, 'ca-backend-')].name" -o tsv)

Copilot uses AI. Check for mistakes.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@Roopan-Microsoft Roopan-Microsoft changed the title docs: merge from dev to main Samplequestion fix: merge from dev to main Nov 10, 2025
@Prajwal-Microsoft Prajwal-Microsoft merged commit a894fff into main Nov 10, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants