Macae rfp af 101725 #621
Merged
Macae rfp af 101725 #621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a method to reset the Magentic workflow context before orchestration runs, ensuring chat history is cleared for each new task. Updates PlanPage to disconnect the WebSocket when cancelling a plan or after agent message processing. Removes unused subscribe/unsubscribe methods from WebSocketService and adds a disconnect log for better traceability.
Deleted the _reset_workflow_context method from OrchestrationManager and its invocation, as it is no longer used. Also updated references from event.agent_id to event.executor_id for consistency in event handling.
Replaces 'executor_id' with 'agent_id' in orchestration_manager event handling for clarity and consistency. Removes redundant clarification prefix in proxy_agent, now passing message text directly. Adds comments to improve code readability.
Removed iter_original_agents and inlined agent/orchestrator state clearing directly in the run method. Now handles clearing of _conversation for orchestrator and _chat_history for agents, with improved logging and error handling.
Fr4nc3
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft and
marktayl1
as code owners
marktayl1
approved these changes
Nov 12, 2025
Fr4nc3
merged commit 83388f1
into
microsoft:macae-rfp-agent-framework
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information