- 
                Notifications
    
You must be signed in to change notification settings  - Fork 434
 
[DE DateTimeV2] Fix for invalid dates #3094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            andrew-gradinari
  wants to merge
  22
  commits into
  microsoft:master
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
purecloudlabs:fix-german-invalid-dates
  
      
      
   
  
    
  
  
  
 
  
      
    base: master
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Open
            
            [DE DateTimeV2] Fix for invalid dates #3094
                    andrew-gradinari
  wants to merge
  22
  commits into
  microsoft:master
from
purecloudlabs:fix-german-invalid-dates
  
      
      
   
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    …n for Units (microsoft#2877) (microsoft#2879) - Support informal degrees in PT and ES (microsoft#2877); - Fix issue in generation of Spanish unit resources; - Re-generate all resources across platforms.
…icrosoft#2878) * Enabling SpanishMexican culture in Number/Unit/DateTimveV2 * Update Spanish number specs according to review Co-authored-by: Colm Dillon <cdillon@ip-192-168-0-108.ec2.internal>
* Add Portuguese DateTime support in Python * Update Specs with Python changes * Fix Number import issue * Update specs according to build and review * Remove empty NotSupported fields from specs
microsoft#2863) (microsoft#2892) Co-authored-by: aitelint <Fabrizio.Sorba@telusinternational.com>
…eTimeRanges (microsoft#2894) * Workaround for TimexProperty.ToString() to not crash on DateTimeRanges * Add TODO for fixing the TimexProperty date range representation properly according to review
Fetch microsoft/Recognizers-Text upstream changes
[NLU-2858] Fetch upstream changes from microsoft:master -> purecloudlabs:master
Merge MS Recognizers into master
Bringing Pureclould Labs master up to-date with Microsoft master
This reverts commit 22f56fd.
Update fork with MS recognizers latest
Sync Fork
aa07831    to
    c026dc8      
    Compare
  
    c026dc8    to
    f11024b      
    Compare
  
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Fix and testing for invalid dates for German.
Details
Invalid dates like "32.04.2023" are being resolved incorrectly:
{ "text": "2.04.", "type_name": "datetimeV2.date", "start": 1, "end": 5, "resolution": { "values": [ { "timex": "XXXX-04-02", "type": "date", "value": "2023-04-02" }, { "timex": "XXXX-04-02", "type": "date", "value": "2024-04-02" } ] } }