Small fixes to sample. #1220
Merged
Small fixes to sample. #1220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvaneerde
approved these changes
Sep 19, 2024
|
In general, changes should target the |
|
Hi @judzmura Thank your taking in these fixes. However I think you forgot the commit (bab2233) from the original pull request. Commit adds missing stuff on the inf file that is referenced by the sample code (most importantly configuration registry keys). Also fixes to kshelper and savedata are missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got some suggestions for fixes/changes to the sample from an external partner, this PR takes some of these small fixes and removes some dead code.