Skip to content

Fixes and updates for StorageCore driver sample components #1294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 26, 2025
Merged

Fixes and updates for StorageCore driver sample components #1294

merged 8 commits into from
Jun 26, 2025

Conversation

1Sisyphus
Copy link

@1Sisyphus 1Sisyphus commented Jun 23, 2025 •
edited
Loading

What changed

  • Fix 1: cpp/drivers/opaque-mdl-use codeql query. Fix for opaque MDL field accesses in classpnp and disk. Use recommended API.
  • Fix 2: cpp/uninitialized-local codeql query. Fix for uninitialized variables during access.
  • Fxi 3: cpp/conditionally-uninitialized-variable codeql rule. Initialize variables that are passed by reference to a function if the status of the function is not checked.
  • Fix 4: Update INF file for lsi_u3 driver to use "$ARCH$" for platform-specific stamping via Stampinf.

How was the change tested

  • For codeql fixes, rerun ruleset again and confirm the issues are gone.
  • For build failures, make sure build succeeds.
  • For the inf, make sure build succeeds for the target platform.

dependabot bot and others added 5 commits May 7, 2025 13:34
@dependabot
Bump tj-actions/changed-files from 41 to 46 in /.github/workflows (mi…
02b59d1 
…crosoft#1283)

Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 41 to 46.
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](tj-actions/changed-files@v41...v46)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@atamene
add explicit cast
a8a0f37
@atamene
inf update for stampif
a4440c5
@atamene
other classpnp and disk fixes
f79d24e
@atamene
comment update
436e197
@1Sisyphus 1Sisyphus changed the base branch from main to develop June 23, 2025 09:53
@1Sisyphus 1Sisyphus marked this pull request as ready for review June 23, 2025 09:54
@1Sisyphus 1Sisyphus requested review from a team as code owners June 23, 2025 09:54
@1Sisyphus
Copy link
Author

@microsoft-github-policy-service agree company="Microsoft"

msscolee
msscolee reviewed Jun 24, 2025
View reviewed changes
@v-junyli v-junyli merged commit 69e8b5f into microsoft:develop Jun 26, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msscolee msscolee msscolee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@1Sisyphus @msscolee @v-junyli @atamene