Skip to content

Minor improvements on deployment manager #5899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2025
Merged

Minor improvements on deployment manager #5899

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cf6599
Using reference in for loop and using variable
guimafelipe Oct 14, 2025
f51ec96
Merge branch 'main' into user/felipeda/smallmanagerfix
guimafelipe Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions dev/Deployment/DeploymentManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ namespace winrt::Microsoft::Windows::ApplicationModel::WindowsAppRuntime::implem
// (i.e. if any of the target packages is not installed, GetStatus should return PackageInstallRequired).
HRESULT verifyResult{};

for (const auto package : c_targetPackages)
for (const auto &package : c_targetPackages)
{
// Build package family name based on the framework naming scheme.
std::wstring packageFamilyName{};
Expand Down Expand Up @@ -651,22 +651,22 @@ namespace winrt::Microsoft::Windows::ApplicationModel::WindowsAppRuntime::implem
auto dependencyPackage{ currentPackageInfo.Package(i) };

// Verify PublisherId matches.
if (CompareStringOrdinal(currentPackageInfo.Package(i).packageId.publisherId, -1, WINDOWSAPPRUNTIME_PACKAGE_PUBLISHERID, -1, TRUE) != CSTR_EQUAL)
if (CompareStringOrdinal(dependencyPackage.packageId.publisherId, -1, WINDOWSAPPRUNTIME_PACKAGE_PUBLISHERID, -1, TRUE) != CSTR_EQUAL)
{
continue;
}

// Verify that the WindowsAppRuntime prefix identifier is in the name.
// This should also be the beginning of the name, so its find position is expected to be 0.
std::wstring dependencyPackageName{ currentPackageInfo.Package(i).packageId.name };
std::wstring dependencyPackageName{ dependencyPackage.packageId.name };
if (dependencyPackageName.find(WINDOWSAPPRUNTIME_PACKAGE_NAME_PREFIX) != 0)
{
continue;
}

// On WindowsAppSDK 1.1+, there is no need to check and rule out Main, Singleton and DDLM Package identifiers as their names don't have a overlap with WINDOWSAPPRUNTIME_PACKAGE_NAME_PREFIX.

return hstring(currentPackageInfo.Package(i).packageFullName);
return hstring(dependencyPackage.packageFullName);
}

THROW_WIN32(ERROR_NOT_FOUND);
Expand Down
Loading