Skip to content

Fix to avoid error when clear cascading field #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix to avoid error when clear cascading field #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 34 additions & 13 deletions src/common/cascading.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,18 @@ class CascadingFieldsService {
}
}

public async resetCascade(field: string): Promise<void[]> {
const index = Object.keys(this.cascadeMap).findIndex(item => item == field);
const fields = Object.values(this.cascadeMap)[index].alters;
const fieldsToReset = new Set<string>(fields);
return Promise.all(
Array.from(fieldsToReset).map(async fieldName => {
const values = await this.workItemService.getAllowedFieldValues(fieldName);
await (this.workItemService as any).filterAllowedFieldValues(fieldName, values);
})
);
}

public async resetAllCascades(): Promise<void[]> {
const fields = flatten(Object.values(this.cascadeMap).map(value => value.alters));
const fieldsToReset = new Set<string>(fields);
Expand Down Expand Up @@ -123,20 +135,29 @@ class CascadingFieldsService {
}

public async performCascading(changedFieldReferenceName: string): Promise<void[]> {
const changedFieldValue = (await this.workItemService.getFieldValue(
changedFieldReferenceName
)) as string;
if (!this.cascadeMap.hasOwnProperty(changedFieldReferenceName)) {
return;
try {
const changedFieldValue = (await this.workItemService.getFieldValue(
changedFieldReferenceName
)) as string;
if (!this.cascadeMap.hasOwnProperty(changedFieldReferenceName)) {
return;
}

if (!changedFieldValue) {
this.resetCascade(changedFieldReferenceName);
return;
}

const affectedFields = this.getAffectedFields(changedFieldReferenceName, changedFieldValue);
const fieldValues = await this.prepareCascadeOptions(affectedFields);

Object.entries(fieldValues).map(async ([fieldName, fieldValues]) => {
await (this.workItemService as any).filterAllowedFieldValues(fieldName, fieldValues);
await this.validateFilterOrClean(fieldName);
});
} catch {
this.cascadeAll();
}

const affectedFields = this.getAffectedFields(changedFieldReferenceName, changedFieldValue);
const fieldValues = await this.prepareCascadeOptions(affectedFields);

Object.entries(fieldValues).map(async ([fieldName, fieldValues]) => {
await (this.workItemService as any).filterAllowedFieldValues(fieldName, fieldValues);
await this.validateFilterOrClean(fieldName);
});
}
}

Expand Down