Skip to content

[#6820] Discrepancy between .NET and JavaScript results when using adaptive expression join() prebuilt function to join array elements #6898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[#6820] Discrepancy between .NET and JavaScript results when using adaptive expression join() prebuilt function to join array elements #6898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion libraries/AdaptiveExpressions/BuiltinFunctions/Join.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using System.Collections;
using System.Linq;
using AdaptiveExpressions.Memory;
using Newtonsoft.Json.Linq;

namespace AdaptiveExpressions.BuiltinFunctions
{
Expand Down Expand Up @@ -34,7 +35,11 @@ private static (object value, string error) EvalJoin(Expression expression, IMem
{
if (args.Count == 2)
{
result = string.Join(args[1].ToString(), list.OfType<object>().Select(x => x.ToString()));
result = string.Join(
args[1].ToString(),
list.OfType<object>()
.SelectMany(x => x is IEnumerable arr && x is not string && x is not JToken ? arr.Cast<object>() : new[] { x })
.Select(x => x?.ToString() ?? string.Empty));
}
else
{
Expand Down
1 change: 1 addition & 0 deletions tests/AdaptiveExpressions.Tests/ExpressionParserTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -996,6 +996,7 @@ public class ExpressionParserTests
Test("join(createArray('a', 'b', 'c'), ',', ' and ')", "a,b and c"),
Test("join(createArray('a', 'b'), ',', ' and ')", "a and b"),
Test("join(createArray(\r\n'a',\r\n 'b'), ','\r\n,\r\n ' and ')", "a and b"),
Test("join(createArray(['a'], ['b'], ['c']), ',')", "a,b,c"),
Test("join(foreach(dialog, item, item.key), ',')", "x,instance,options,title,subTitle"),
Test("join(foreach(dialog, item => item.key), ',')", "x,instance,options,title,subTitle"),
Test("foreach(dialog, item, item.value)[1].xxx", "instance"),
Expand Down