Expand TestBot + Add tests (#1022)

* port over CoreBot dialogs into testBot
write unit tests for testbot using botbuilder-testing

* update package log

* update

* add testbot to package update stuff

* adjust package

* restore mybot url and class

* updates per comments

* add more tests

* add all tests for parity with c#

* test outcome of booking dialog

* new tests for dateresolver

* add spoken output to booking dialog

* remove unused paramter

* Update mainDialog constructor, add inputhint, replace dialog, airpot not found warning

* Fix unsupportedCities array length check

* Refactor luisHelper / FlightBookingRecognizer, update tests

* Update test

* Refactoring of MainDialog, flightBookingRecognizer and tests

* Add luis config check in mainDialog actStep function

* Renamed test files from tests.js to test.js to match naming pattern in botbuilder.
Renamed some test cases to use the same capitalization as bot builder.
Added empty .env file.
Added general .gitignore.
Added TSConfig

* Renamed test

* Updated instantiation of DialogTestClient to match the latest changes from master.
Removed unnecesary tests for creating DialogTestClient instance.
Renamed dialog variables as sut (systemt under test) to match the documentation.
Fixed some tests (need to fix others)

* Updated MainDialog to handle LUIS intents, show warnings for unsupported cities and work the same as the dotnet one.
Added helper methods to extract LUIS values for composite entities and datetime to FlightBookingRecognizer.
Added luis result json captures to testdata so we can write tests for entity extraction based on serialized results.
Updated BookingDialog to use proper text, speak and inputhints.
Updated DateResolverDialog to use proper text, speak and inputhints.
Removed onBeginDialog from cancelAndHelpDialog to avoid handling interruptions on turn 0.
Removed myBot.

* Formatting and comments in MaindDialog
Updated deployment template to point to messages instead of mybot.

* trying to fix the build by removing testbo from package.json

* reverted changes

* Updated bookingDialog logic and test data to match dotnet.

* updated tests to use testCases.map instead of for loop.
updated dateResolveDialog tests to use strictEquals.

* Touched file to kick off build.

* Changed flightBookingRecognizer so it caches the instance of the recognizer rather than creating one on each call.
Implemented 3 of for test scenarios for mainDialog (with mock dialogs and mock recognizer).
deleted unused mainDialogTestCases.
Updated other tests to use => instead of function().
Changed the oreder of constructor params for mainDialog.

* Implemented showWarningMessage tests for MainDialog.
Added placeholder for cancelAndHelpDialog.tests.

* Implemented CancelAndHelpDialog tests.

* Moved dialog tests into a dialogs folder.

* Implemented DialogAndWelcomeBot tests

* Added some comments to the code

* Updated comments.

* Updated confirm prompt to say "is this correct"
Moved MockBookingDialogWithPrompt outside the test case for clarity.

Author: benbrown

libraries/testbot/.env

@@ -1,2 +1,5 @@
 MicrosoftAppId=
-MicrosoftAppPassword=
+MicrosoftAppPassword=
+LuisAppId=
+LuisAPIKey=
+LuisAPIHostName=

libraries/testbot/.gitignore

@@ -0,0 +1,5 @@
+/**/node_modules
+/**/.vscode
+/**/lib
+coverage
+.nyc_output

libraries/testbot/bots/dialogAndWelcomeBot.js

@@ -0,0 +1,28 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+const { CardFactory } = require('botbuilder-core');
+const { DialogBot } = require('./dialogBot');
+const WelcomeCard = require('./resources/welcomeCard.json');
+
+class DialogAndWelcomeBot extends DialogBot {
+    constructor(conversationState, userState, dialog, logger) {
+        super(conversationState, userState, dialog, logger);
+
+        this.onMembersAdded(async (context, next) => {
+            const membersAdded = context.activity.membersAdded;
+            for (let cnt = 0; cnt < membersAdded.length; cnt++) {
+                if (membersAdded[cnt].id !== context.activity.recipient.id) {
+                    const welcomeCard = CardFactory.adaptiveCard(WelcomeCard);
+                    await context.sendActivity({ attachments: [welcomeCard] });
+                    await dialog.run(context, conversationState.createProperty('DialogState'));
+                }
+            }
+
+            // By calling next() you ensure that the next BotHandler is run.
+            await next();
+        });
+    }
+}
+
+module.exports.DialogAndWelcomeBot = DialogAndWelcomeBot;

libraries/testbot/bots/dialogBot.js

@@ -0,0 +1,51 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+const { ActivityHandler } = require('botbuilder');
+
+class DialogBot extends ActivityHandler {
+    /**
+     *
+     * @param {ConversationState} conversationState
+     * @param {UserState} userState
+     * @param {Dialog} dialog
+     * @param {any} logger object for logging events, defaults to console if none is provided
+     */
+    constructor(conversationState, userState, dialog, logger) {
+        super();
+        if (!conversationState) throw new Error('[DialogBot]: Missing parameter. conversationState is required');
+        if (!userState) throw new Error('[DialogBot]: Missing parameter. userState is required');
+        if (!dialog) throw new Error('[DialogBot]: Missing parameter. dialog is required');
+        if (!logger) {
+            logger = console;
+            logger.log('[DialogBot]: logger not passed in, defaulting to console');
+        }
+
+        this.conversationState = conversationState;
+        this.userState = userState;
+        this.dialog = dialog;
+        this.logger = logger;
+        this.dialogState = this.conversationState.createProperty('DialogState');
+
+        this.onMessage(async (context, next) => {
+            this.logger.log('Running dialog with Message Activity.');
+
+            // Run the Dialog with the new message Activity.
+            await this.dialog.run(context, this.dialogState);
+
+            // By calling next() you ensure that the next BotHandler is run.
+            await next();
+        });
+
+        this.onDialog(async (context, next) => {
+            // Save any state changes. The load happened during the execution of the Dialog.
+            await this.conversationState.saveChanges(context, false);
+            await this.userState.saveChanges(context, false);
+
+            // By calling next() you ensure that the next BotHandler is run.
+            await next();
+        });
+    }
+}
+
+module.exports.DialogBot = DialogBot;

libraries/testbot/bots/myBot.js

@@ -0,0 +1,46 @@
+{
+  "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
+  "type": "AdaptiveCard",
+  "version": "1.0",
+  "body": [
+    {
+      "type": "Image",
+      "url": "https://encrypted-tbn0.gstatic.com/images?q=tbn:ANd9GcQtB3AwMUeNoq4gUBGe6Ocj8kyh3bXa9ZbV7u1fVKQoyKFHdkqU",
+      "size": "stretch"
+    },
+    {
+      "type": "TextBlock",
+      "spacing": "medium",
+      "size": "default",
+      "weight": "bolder",
+      "text": "Welcome to Bot Framework!",
+      "wrap": true,
+      "maxLines": 0
+    },
+    {
+      "type": "TextBlock",
+      "size": "default",
+      "isSubtle": "yes",
+      "text": "Now that you have successfully run your bot, follow the links in this Adaptive Card to expand your knowledge of Bot Framework.",
+      "wrap": true,
+      "maxLines": 0
+    }
+  ],
+  "actions": [
+    {
+      "type": "Action.OpenUrl",
+      "title": "Get an overview",
+      "url": "https://docs.microsoft.com/en-us/azure/bot-service/?view=azure-bot-service-4.0"
+    },
+    {
+      "type": "Action.OpenUrl",
+      "title": "Ask a question",
+      "url": "https://stackoverflow.com/questions/tagged/botframework"
+    },
+    {
+      "type": "Action.OpenUrl",
+      "title": "Learn how to deploy",
+      "url": "https://docs.microsoft.com/en-us/azure/bot-service/bot-builder-howto-deploy-azure?view=azure-bot-service-4.0"
+    }
+  ]
+}