demikernel: v12: series of patches with code improvements#1618
Merged
anandbonde merged 6 commits intodevfrom Jul 18, 2025
Merged
demikernel: v12: series of patches with code improvements#1618anandbonde merged 6 commits intodevfrom
anandbonde merged 6 commits intodevfrom
Conversation
iyzhang
approved these changes
Jul 18, 2025
There is no need of these variables becuase they are just returned immediately.
cause is already a &, so no need to take a ref to ref again.
Reduced unnecessary indirection via a `cause` variable, instead it's ok to inline the msg because of close proximity of use. Also, it makes the code far easier and faster to parse. Additionally, these are error paths (i.e., off critical path), so there is no need to optimize here.
These lifetime annotations are unnecessary, they just add line noise.
There is no need to clone addr because the ownership can be cleanly transfered to the callee.
Use a more idiomatic syntax for create default followed by field assignment. Also cleanup code in the same file.
anandbonde
force-pushed
the
ab-cleanup-v12
branch
from
47e1d6b to
3660086
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is v12 of the series of patches that focus on code clarity and simplification. Refer to individual commits for reasoning.