Skip to content

Commit 35e73e4

Browse files
committed
containerized-testing-tool: Minor fixes in Dockerfile, Makefile and README
- Remove the extra step for creating /results in Dockerfile - Modify Makefile to add build dependency and .PHONY for each target - Update README.md Signed-off-by: Ankita Pareek <ankitapareek@microsoft.com>
1 parent 1898596 commit 35e73e4

File tree

3 files changed

+7
-15
lines changed

3 files changed

+7
-15
lines changed

tests/kata-containerized-test-tool/Dockerfile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@ RUN tdnf update -y && tdnf install -y \
1010
iproute \
1111
&& tdnf clean all
1212

13-
RUN mkdir -p /results
14-
1513
# Default environment variables
1614
ENV ENABLED_TESTS=""
1715

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,16 @@
1-
.PHONY: build docker clean
2-
31
BINARY_NAME=kata-containerized-test-tool
42

3+
.PHONY: build
54
build:
65
go build -o $(BINARY_NAME) cmd/katatest/main.go
76

8-
docker:
7+
.PHONY: docker
8+
docker: build
99
docker build -t kata-test-container .
1010

11+
.PHONY: clean
1112
clean:
1213
rm -f $(BINARY_NAME)
1314

15+
.PHONY: all
1416
all: clean build docker

tests/kata-containerized-test-tool/README.md

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,7 @@ This tool provides a flexible framework for running tests in both standard conta
1515

1616
### Build Steps
1717

18-
1. Clone the repository
19-
20-
```
21-
git clone https://github.com/kata-containers/kata-containers.git
22-
cd kata-containers/kata-containerized-testing-tool
23-
go mod tidy
24-
```
25-
26-
2. Build the binary and the container
18+
Build the binary and the container
2719

2820
- Using Makefile
2921
```
@@ -86,7 +78,7 @@ sudo ctr run \
8678
yourregistry.azurecr.io/kata-test-container:v1 host-test
8779
```
8880

89-
#### UVM
81+
#### Guest VM
9082
```
9183
sudo ctr run \
9284
--cni \

0 commit comments

Comments
 (0)