-
Notifications
You must be signed in to change notification settings - Fork 38
node-builder: add virtio-blk kata pod sandboxing and separate out tardev-snapshotter build #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: msft-main-3.2.0
Are you sure you want to change the base?
Conversation
2855780
to
beb9b8a
Compare
5fa2080
to
da7eea9
Compare
f892b22
to
b78eea2
Compare
…dev-snapshotter build This PR is to support new virtio-blk kata pod sandboxing runtime. It adds new runtime config, adjusts dependencies for kata pod sandboxing in general, and extract tardev-snapshotter build and install steps into separate scripts. Signed-off by: Mitch Zhu <mitchzhu@microsoft.com>
b78eea2
to
851c863
Compare
I think this PR can be split into two: One PR which refactors the tardev-snapshotter build parts without modifying the pod sandboxing build parts. Another PR which changes the pod sandboxing build path to build with tardev-snapshotter included and with a virtio-blk secondary configuration included |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments, vote to split. On hold for now.
Note: To add required packages for kata UVM to list of packages (config.sh) as long as these are not found on the PMC meta-package |
Merge Checklist
upstream/missing
label (orupstream/not-needed
) has been set on the PR.Summary
Test Methodology