Implements MsQuicStreamOpenWithDeadline for deadline aware streams #5244
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Draft PR, requesting comments
Core changes made to
send.c
,stream_send.c
.Added file
deadline_engine.c
Implements Deadline Awareness to streams as described in #5200 with some changes.
Thank you @nibanks for some ideas.
This PR aims to introduce a function
StreamOpenWithDeadline()
The goal of this function is the allow users to open streams which aim to drain the data queued into it within the mentioned deadline. This is achieved by making a minor change to
QuicStreamSendCanWriteDataFrames
where we also check if all the queued data can be drained before the deadline which is a statistical guess made by theDrainBeforeDeadlineEngine
.The
DrainBeforeDeadlineEngine
is implemented in a new filedeadline_engine.c
and uses information from the Congestion control system to make the "guess".Due to it's dependence on the CongestionControl we use some internal congestion control information which are not exposed using an API (see the enum in
deadline_engine.c
). Requesting comments and preferred alternative solution on this dirty practice.Testing
Added a basic sanity test for Deadline of 0ms and very large but valid deadline.
Requesting the PR be marked as draft until accuracy of deadline engine is measured.
Documentation
No documentation changes as of now.
To Do: