Merge pull request #77 from engines-dev/start-new-session

Let language server subprocess be its own process group

Author: LakshyAAAgrawal

src/multilspy/language_server.py

@@ -159,7 +159,11 @@ def logging_fn(source, target, msg):
 
         # cmd is obtained from the child classes, which provide the language specific command to start the language server
         # LanguageServerHandler provides the functionality to start the language server and communicate with it
-        self.server: LanguageServerHandler = LanguageServerHandler(process_launch_info, logger=logging_fn)
+        self.server: LanguageServerHandler = LanguageServerHandler(
+            process_launch_info,
+            logger=logging_fn,
+            start_independent_lsp_process=config.start_independent_lsp_process,
+        )
 
         self.language_id = language_id
         self.open_file_buffers: Dict[str, LSPFileBuffer] = {}

src/multilspy/lsp_protocol_handler/server.py

@@ -172,9 +172,18 @@ class LanguageServerHandler:
             the asynchronous tasks created by the handler.
         task_counter: An integer that represents the next available task id for the handler.
         loop: An asyncio.AbstractEventLoop object that represents the event loop used by the handler.
+        start_independent_lsp_process: An optional boolean flag that indicates whether to start the
+        language server process in an independent process group. Default is `True`. Setting it to
+        `False` means that the language server process will be in the same process group as the
+        the current process, and any SIGINT and SIGTERM signals will be sent to both processes.
     """
 
-    def __init__(self, process_launch_info: ProcessLaunchInfo, logger=None) -> None:
+    def __init__(
+        self,
+        process_launch_info: ProcessLaunchInfo,
+        logger=None,
+        start_independent_lsp_process=True,
+    ) -> None:
         """
         Params:
             cmd: A string that represents the command to launch the language server process.
@@ -196,6 +205,7 @@ def __init__(self, process_launch_info: ProcessLaunchInfo, logger=None) -> None:
         self.tasks = {}
         self.task_counter = 0
         self.loop = None
+        self.start_independent_lsp_process = start_independent_lsp_process
 
     async def start(self) -> None:
         """
@@ -211,6 +221,7 @@ async def start(self) -> None:
             stderr=asyncio.subprocess.PIPE,
             env=child_proc_env,
             cwd=self.process_launch_info.cwd,
+            start_new_session=self.start_independent_lsp_process,
         )
 
         self.loop = asyncio.get_event_loop()

src/multilspy/multilspy_config.py

@@ -30,6 +30,7 @@ class MultilspyConfig:
     """
     code_language: Language
     trace_lsp_communication: bool = False
+    start_independent_lsp_process: bool = True
 
     @classmethod
     def from_dict(cls, env: dict):
@@ -40,4 +41,4 @@ def from_dict(cls, env: dict):
         return cls(**{
             k: v for k, v in env.items() 
             if k in inspect.signature(cls).parameters
-        })
+        })