[WIP] enable using vcpkg for Dawn #24699
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fs-eire
commented
May 9, 2025
fs-eire
commented
May 9, 2025
fs-eire
commented
May 9, 2025
|
|
||
| vcpkg_from_github( | ||
| OUT_SOURCE_PATH SOURCE_PATH | ||
| REPO fs-eire/dawn |
There was a problem hiding this comment.
will update to official dawn before merging.
currently using my fork for easier iteration.
fs-eire
commented
May 9, 2025
| # explicitly set the jinja2 and markupsafe directories to empty strings | ||
| # when they are empty, the python script will import them from the system | ||
| # | ||
| # pip install jinja2 markupsafe |
There was a problem hiding this comment.
how to manage these 2 dependencies?
we can use the pip install on the CI machine, but it's easy to fail on a local build. Better to have a way to allow vcpkg to do that for us.
fs-eire
force-pushed
the
dawn-vcpkg
branch
5 times, most recently
from
a797876 to
511ac36
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
fs-eire
force-pushed
the
dawn-vcpkg
branch
2 times, most recently
from
c2dc78d to
b2634fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Still WIP.
changes in dawn: fs-eire/dawn@ort-main...ort-vcpkg
Motivation and Context