[QNN-EP] - Tie HTP power config id lifetime to session #26457
+86
−163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove PerThreadContext (Only used for id management) - Create ManagedHtpPowerConfigId to manage destruction of id - Only create one htp power config id per session
| if (IsHtpPowerConfigIdValid()) { | ||
| if (qnn::HtpPerformanceMode::kHtpDefault != htp_performance_mode) { | ||
| ORT_RETURN_IF_ERROR(qnn_backend_manager_->SetHtpPowerConfig(GetPerThreadContext().GetHtpPowerConfigId(), | ||
| ORT_RETURN_IF_ERROR(qnn_backend_manager_->SetHtpPowerConfig(GetHtpPowerConfigId(), |
Contributor
There was a problem hiding this comment.
When a session is used across multiple threads, is it possible that they can interfere with each other here (and in other places where the EP calls qnn_backend_manager_->Set*PowerConfig.)?
The mutex is only locked during the call to GetHtpPowerConfigId() but there is no synchronization here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
One session can potentially be used on multiple threads for execution, and there is a set max number of htp power config ids that can be used at any given time. If enough sessions and enough threads are created, then the maximum number of power config ids can be reached easily (see ticket).
Additionally, all power configurations are available on a per-session basis. Therefore, there is no reason to have more than one power config id per session.
Removal of PerThreadContext is due to the fact that it was only used to contain and destroy the power config ids on thread termination. As such, there is no more need for PerThreadContext.