Propagate EP session option modifications during provider creation#28154
Closed
KenLagos wants to merge 1 commit intomicrosoft:mainfrom
Closed
Propagate EP session option modifications during provider creation#28154KenLagos wants to merge 1 commit intomicrosoft:mainfrom
KenLagos wants to merge 1 commit intomicrosoft:mainfrom
Conversation
passing it to IExecutionProviderFactory::CreateProvider. This ensures that any modifications made by an EP during creation (e.g., disabling memory pattern optimization) are reflected in the actual session options used during initialization. Previously, EP-side modifications to session options could be lost.
Author
|
@microsoft-github-policy-service agree company="AMD" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wrap the session's mutable SessionOptions in an OrtSessionOptions before passing it to IExecutionProviderFactory::CreateProvider. This ensures that any modifications made by an EP during creation (e.g., disabling memory pattern optimization) are reflected in the actual session options used during initialization. Previously, EP-side modifications to session options could be lost.
Motivation and Context
It would be nice to have control over which session options to enable/disable during plugin ep creation. For example, calls like ort_api.DisableMemPattern(const_cast<OrtSessionOptions*>(session_options)); during plugin ep creation were not being reflected in actual session options used during initialization.