Update IdentifierUtils #394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…/powerquery-parser into dev/jobolton/parseMode
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the IdentifierUtils module to improve identifier handling and normalization capabilities, while also fixing a bug in the type utilities.
- Adds new functions
getNormalizedIdentifierandgetAllowedIdentifiersfor better identifier management - Updates the
getIdentifierKindfunction to use an options parameter instead of boolean flags - Fixes a logical error in
isEqualFunctionParameterthat was returning incorrect comparison results
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/powerquery-parser/language/identifierUtils.ts | Major refactor adding new identifier utility functions and updating existing APIs |
| src/powerquery-parser/language/type/typeUtils/isEqualType.ts | Fixes logical bug in isEqualFunctionParameter function |
| src/powerquery-parser/parser/parsers/naiveParseSteps.ts | Updates call to getIdentifierKind to use new options parameter |
| src/powerquery-parser/parser/nodeIdMap/nodeIdMapIterator.ts | Updates calls to use new getNormalizedIdentifier function |
| src/powerquery-parser/lexer/lexer.ts | Updates call to getIdentifierLength to use new options parameter |
| src/test/libraryTest/identifierUtils.test.ts | Comprehensive test updates for new identifier utility functions |
| src/test/libraryTest/language/typeUtils/isEqualType.test.ts | Adds test for function type equality |
| package.json | Version bump to 0.18.0 |
amv146
reviewed
Aug 11, 2025
| break; | ||
|
|
||
| case IdentifierRegexpState.RegularIdentifier: | ||
| if (text[index] === ".") { |
There was a problem hiding this comment.
can you give an example of some of the states here? for example, i don't understand the "2 sequential periods == done" thing
|
|
||
| export function isRegularIdentifier(text: string, allowTrailingPeriod: boolean): boolean { | ||
| return getIdentifierLength(text, 0, allowTrailingPeriod) === text.length; | ||
| function insertQuotes(text: string): string { |
There was a problem hiding this comment.
can we name this function "makeQuoted" or something instead? "insertQuotes" makes it sound like it will insert anywhere.
amv146
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
foocan also be#"foo")Small other fix I was to lazy to split out into another PR: