Skip to content

Conversation

JordanBoltonMN
Copy link
Contributor

  1. Adds identifierExpressionUtils
  2. Adds assertNormalizedPath for identifierUtils
  3. Allows hash keywords as identifiers

@JordanBoltonMN JordanBoltonMN requested a review from Copilot August 26, 2025 18:28
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances identifier handling in the PowerQuery parser by adding support for identifier expressions and hash keywords as identifiers. The changes introduce new utilities for processing identifier expressions with '@' prefixes and expand identifier support to include hash keywords like #table.

  • Added IdentifierExpressionUtils module for handling identifier expressions with '@' prefixes
  • Enhanced identifierUtils to support hash keywords as valid identifiers
  • Added assertNormalizedPath utility function for identifier validation

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/test/libraryTest/identifierExpressionUtils.test.ts New comprehensive test suite for identifier expression utilities
src/test/libraryTest/identifierUtils.test.ts Added test case for hash keyword identifier support
src/powerquery-parser/language/identifierExpressionUtils.ts New utility module for processing identifier expressions with '@' prefixes
src/powerquery-parser/language/identifierUtils.ts Added hash keyword support and assertNormalizedIdentifier function
src/powerquery-parser/language/index.ts Export declaration for new IdentifierExpressionUtils module
package.json Version bump to 0.18.1

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@JordanBoltonMN JordanBoltonMN merged commit b32992f into master Aug 26, 2025
5 checks passed
@JordanBoltonMN JordanBoltonMN deleted the dev/jobolton/identifierExpressionUtils branch August 26, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants