Skip to content

Conversation

ninghu
Copy link
Member

@ninghu ninghu commented Jul 23, 2024

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • I confirm that all new dependencies are compatible with the MIT license.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

github-actions bot commented Jul 23, 2024

promptflow SDK CLI Azure E2E Test Result users/ninhu/content_safety_to_async

  4 files    4 suites   4m 21s ⏱️
244 tests 204 ✅  40 💤 0 ❌
976 runs  816 ✅ 160 💤 0 ❌

Results for commit 0456d1a.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 23, 2024

promptflow-evals test result

 12 files  ±  0   12 suites  ±0   1h 23m 48s ⏱️ + 15m 2s
 13 tests  -  27   13 ✅  -  26  0 💤  -  1  0 ❌ ±0 
156 runs   - 324  156 ✅  - 312  0 💤  - 12  0 ❌ ±0 

Results for commit 0456d1a. ± Comparison against base commit fda05ab.

This pull request removes 40 and adds 13 tests. Note that renamed tests count towards both.
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_composite_evaluator_chat[False-True]
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_composite_evaluator_chat[True-True]
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_composite_evaluator_qa[False]
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_composite_evaluator_qa[True]
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_qa_evaluator_for_nans
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_quality_evaluator_coherence
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_quality_evaluator_fluency
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_quality_evaluator_groundedness
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_quality_evaluator_prompt_based_with_dict_input
tests.evals.e2etests.test_builtin_evaluators.TestBuiltInEvaluators ‑ test_quality_evaluator_relevance
…
tests.evals.e2etests.test_adv_simulator.TestAdvSimulator ‑ test_adv_conversation_sim_responds_with_responses
tests.evals.e2etests.test_adv_simulator.TestAdvSimulator ‑ test_adv_qa_sim_responds_with_one_response
tests.evals.e2etests.test_adv_simulator.TestAdvSimulator ‑ test_adv_rewrite_sim_responds_with_responses
tests.evals.e2etests.test_adv_simulator.TestAdvSimulator ‑ test_adv_sim_init_with_prod_url
tests.evals.e2etests.test_adv_simulator.TestAdvSimulator ‑ test_adv_summarization_jailbreak_sim_responds_with_responses
tests.evals.e2etests.test_adv_simulator.TestAdvSimulator ‑ test_adv_summarization_sim_responds_with_responses
tests.evals.e2etests.test_adv_simulator.TestAdvSimulator ‑ test_incorrect_scenario_raises_error
tests.evals.e2etests.test_evaluate.TestEvaluate ‑ test_evaluate_track_in_cloud
tests.evals.e2etests.test_evaluate.TestEvaluate ‑ test_evaluate_track_in_cloud_no_target
tests.evals.e2etests.test_evaluate.TestEvaluate ‑ test_evaluate_with_content_safety_evaluator
…

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 23, 2024

SDK CLI Test Result users/ninhu/content_safety_to_async

    4 files      4 suites   1h 6m 24s ⏱️
  786 tests   763 ✅ 23 💤 0 ❌
3 144 runs  3 052 ✅ 92 💤 0 ❌

Results for commit 0456d1a.

♻️ This comment has been updated with latest results.

@ninghu ninghu changed the title [pf-evals] Convert content safety evaluators to async based implementations [pf-evals] Convert content safety evaluators to async based implementation Jul 23, 2024
@ninghu ninghu marked this pull request as ready for review July 23, 2024 17:01
@ninghu ninghu requested review from a team as code owners July 23, 2024 17:01
@ninghu ninghu changed the title [pf-evals] Convert content safety evaluators to async based implementation [pf-evals] Convert content safety and f1 score to async-enabled implementation Jul 23, 2024
nick863
nick863 previously approved these changes Jul 23, 2024
wangchao1230
wangchao1230 previously approved these changes Jul 24, 2024
@ninghu ninghu merged commit c1f0f6d into main Jul 25, 2024
86 of 87 checks passed
@ninghu ninghu deleted the users/ninhu/content_safety_to_async branch July 25, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants