Skip to content

Fix issue #1892 #1901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fix issue #1892 #1901

wants to merge 3 commits into from

Conversation

fibers
Copy link
Contributor

@fibers fibers commented Mar 28, 2025 •
edited
Loading

Description

Motivation and Context

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

@github-actions github-actions bot added the waiting for triage Cannot auto-triage, wait for triage. label Mar 28, 2025
@fibers
Copy link
Contributor Author

fibers commented Mar 28, 2025

@microsoft-github-policy-service agree

@fibers fibers changed the title Fix issue 1892 Fix issue #1892 Mar 28, 2025
@fibers
Copy link
Contributor Author

fibers commented Mar 28, 2025

fix #1892

@SunsetWolf
Copy link
Collaborator

Hi, @fibers
Please pull the latest main branch, this will fix the CI error.

@SunsetWolf
Copy link
Collaborator

Hi, @fibers
On top of this PR, I fixed the CI issue, and created a new PR, which now looks great, and of course your commits are preserved, thank you very much. This PR will be closed soon.

@SunsetWolf SunsetWolf closed this Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
waiting for triage Cannot auto-triage, wait for triage.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fibers @SunsetWolf