chore: set new architecture as the default #2688
Open
+403
−154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft#2423)" This reverts commit f2a6793.
tido64
reviewed
Sep 11, 2025
| @@ -157,6 +157,6 @@ def self.extract_react_native_version(react_native_path, file_manager: File, jso | |||
| end | |||
|
|
|||
| def self.new_arch_enabled | |||
| return ENV["RCT_NEW_ARCH_ENABLED"] == "1" # [macOS] Disable Fabric by default till macOS supports it | |||
| return ENV["RCT_NEW_ARCH_ENABLED"] == nil || ENV["RCT_NEW_ARCH_ENABLED"] == "1" | |||
There was a problem hiding this comment.
0.79-stable seems to be using this instead (are we not yet caught up?):
Suggested change
| return ENV["RCT_NEW_ARCH_ENABLED"] == nil || ENV["RCT_NEW_ARCH_ENABLED"] == "1" | |
| return ENV["RCT_NEW_ARCH_ENABLED"] == '0' ? false : true |
Although strictly speaking, they should be using this:
Suggested change
| return ENV["RCT_NEW_ARCH_ENABLED"] == nil || ENV["RCT_NEW_ARCH_ENABLED"] == "1" | |
| return ENV["RCT_NEW_ARCH_ENABLED"] != '0' |
There was a problem hiding this comment.
Interesting. Maybe the same code path got updated in 0.79 after I did the first revert. I'll double check everything
There was a problem hiding this comment.
Wait... so then 0.79 probably shipped with new arch on by default.
There was a problem hiding this comment.
It's been enabled by default since 0.76: https://reactnative.dev/blog/2024/10/23/release-0.76-new-architecture#react-native-new-architecture-by-default
|
|
||
| PODFILE CHECKSUM: 07eddbe098f0e50aff590a91207f692788a9fe4c | ||
|
|
||
| COCOAPODS: 1.16.2 | ||
| COCOAPODS: 1.15.2 |
There was a problem hiding this comment.
Yes.. for some reason my machine refuses to install. 1.16.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Revert #2423 in prep for the new architecture as the default for RNM 0.80+