Skip to content

feat: add support for bazel #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 7, 2025
Merged

feat: add support for bazel #759

merged 11 commits into from
May 7, 2025

Conversation

jayakasadev
Copy link
Contributor

  • Add support for bazel to allow users to add snmalloc as a dependency and use in their projects
  • Create fuzztest test target using snmalloc

@jayakasadev
Copy link
Contributor Author

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree

@mjp41
Copy link
Member

mjp41 commented Mar 21, 2025

@jayakasadev thanks for doing this. I am afraid I am not familiar with Bazel, so I find this a bit hard to review, but I'll try my best ;-) @SchrodingerZhu are you familiar with Bazel? If so, would you be able to take a pass of this?

@jayakasadev, Do you think you would be able to add a couple of build targets to the github actions to build this with Bazel? I am concerned that I will break things down the line without CI checking this.

@jayakasadev jayakasadev force-pushed the main branch 2 times, most recently from dfe05be to 513797d Compare March 21, 2025 19:42
@SchrodingerZhu
Copy link
Collaborator

I am not that familiar with Bazel while I do have worked on it a bit due to LLVM's adoption. I am scanning through the PR now.

@jayakasadev jayakasadev requested a review from devnexen March 24, 2025 19:38
@jayakasadev jayakasadev force-pushed the main branch 2 times, most recently from 086ea00 to d908d33 Compare March 24, 2025 20:46
Copy link
Collaborator

@SchrodingerZhu SchrodingerZhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other parts looks good to me. Please address devnexen's concern.

@jayakasadev jayakasadev requested a review from devnexen March 28, 2025 14:11
@devnexen
Copy link
Collaborator

@SchrodingerZhu feels free to merge :)

@jayakasadev
Copy link
Contributor Author

@SchrodingerZhu lmk if anymore changes are needed

@mjp41
Copy link
Member

mjp41 commented Apr 28, 2025

@jayakasadev would you be able to rebase/merge the latest main please. I can't get the interface to let me move it forward to get a clean CI run. Thanks

@jayakasadev
Copy link
Contributor Author

@mjp41 lmk about any more changes

@mjp41
Copy link
Member

mjp41 commented May 7, 2025

@mjp41 lmk about any more changes

Sorry, I have been working on another project with a tight deadline, and forgot to check back in on this.

@mjp41 mjp41 merged commit a63f0c1 into microsoft:main May 7, 2025
77 checks passed
@mjp41
Copy link
Member

mjp41 commented May 7, 2025

@jayakasadev thanks for doing this.

@jayakasadev
Copy link
Contributor Author

if there is interest, I could help with the rust bindings using bazel similar to this

cc @SchrodingerZhu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants