-
Notifications
You must be signed in to change notification settings - Fork 116
feat: add support for bazel #759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@microsoft-github-policy-service agree |
@jayakasadev thanks for doing this. I am afraid I am not familiar with Bazel, so I find this a bit hard to review, but I'll try my best ;-) @SchrodingerZhu are you familiar with Bazel? If so, would you be able to take a pass of this? @jayakasadev, Do you think you would be able to add a couple of build targets to the github actions to build this with Bazel? I am concerned that I will break things down the line without CI checking this. |
dfe05be
to
513797d
Compare
I am not that familiar with Bazel while I do have worked on it a bit due to LLVM's adoption. I am scanning through the PR now. |
086ea00
to
d908d33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other parts looks good to me. Please address devnexen's concern.
@SchrodingerZhu feels free to merge :) |
@SchrodingerZhu lmk if anymore changes are needed |
@jayakasadev would you be able to rebase/merge the latest main please. I can't get the interface to let me move it forward to get a clean CI run. Thanks |
@mjp41 lmk about any more changes |
Sorry, I have been working on another project with a tight deadline, and forgot to check back in on this. |
@jayakasadev thanks for doing this. |
if there is interest, I could help with the rust bindings using bazel similar to this |
snmalloc
as a dependency and use in their projects