Skip to content

Commit bbde564

Browse files
authored
Use SkipTrivia instead of GetRangeOfTokenAtPosition where possible (#2089)
1 parent bbaa0f5 commit bbde564

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

internal/checker/checker.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3968,7 +3968,7 @@ func (c *Checker) checkWithStatement(node *ast.Node) {
39683968
c.checkExpression(node.Expression())
39693969
sourceFile := ast.GetSourceFileOfNode(node)
39703970
if !c.hasParseDiagnostics(sourceFile) {
3971-
start := scanner.GetRangeOfTokenAtPosition(sourceFile, node.Pos()).Pos()
3971+
start := scanner.SkipTrivia(sourceFile.Text(), node.Pos())
39723972
end := node.Statement().Pos()
39733973
c.grammarErrorAtPos(sourceFile.AsNode(), start, end-start, diagnostics.The_with_statement_is_not_supported_All_symbols_in_a_with_block_will_have_type_any)
39743974
}

internal/ls/lsutil/utilities.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ func ProbablyUsesSemicolons(file *ast.SourceFile) bool {
3737
astnav.GetStartOfNode(lastToken, file, false /*includeJSDoc*/))
3838
nextTokenLine := scanner.GetECMALineOfPosition(
3939
file,
40-
scanner.GetRangeOfTokenAtPosition(file, lastToken.End()).Pos())
40+
scanner.SkipTrivia(file.Text(), lastToken.End()))
4141
// Avoid counting missing semicolon in single-line objects:
4242
// `function f(p: { x: string /*no semicolon here is insignificant*/ }) {`
4343
if lastTokenLine != nextTokenLine {

0 commit comments

Comments
 (0)