Add configurable concurrency option #1176
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a configurable concurrency option, replacing the old single-threaded testing flag with a new --concurrency flag that allows detailed control over the number of checkers and threads used during compilation. Key changes include:
- Adding a new "concurrency" field to compiler options and command line declarations.
- Creating a new core package for parsing and handling concurrency values.
- Updating test utilities, the compiler runner, and CI configurations to support the new flag.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/tsoptions/parsinghelpers.go | Added parsing for "concurrency" flag in compiler options. |
| internal/tsoptions/declscompiler.go | Declared the new "concurrency" option for the compiler. |
| internal/testutil/harnessutil/harnessutil.go | Set default concurrency from environment if not provided via flag. |
| internal/testrunner/compiler_runner.go | Updated concurrency condition for skipping error baselines. |
| internal/core/concurrency.go | Introduced parsing logic and tests for various concurrency values. |
| internal/compiler/program.go | Updated program initialization to use new concurrency settings. |
| Herebyfile.mjs | Updated environment variable usage to use "concurrency" instead of the old flag. |
| .github/workflows/ci.yml | Updated environment variable in CI to support the new concurrency flag. |
jakebailey
force-pushed
the
jabaile/concurrency-options
branch
from
5eb5b31 to
99fc50c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an experimental
--concurrencyflag. Example usage:--concurrency <default|auto|on|yes>- default behavior, uses 4 checkers, plus all cores for parse/bind/emit. Theoretically we could change this to some magic algorithm.--concurrency <single|off|no>,--singleThreaded- one checker, single threaded parse/bind/emit.--concurrency max- UsesGOMAXPROCScheckers, plus all cores for parse/bind/emit.--concurrency half- UsesGOMAXPROCS/2checkers, plus all cores for parse/bind/emit. (For me, this option is best for checking VS Code.)--concurrency 10- Uses 10 checkers, plus all cores for parse/bind/emit. Can be any number all the way up to the number of files.--concurrency checker-per-filecreates a checker for every file; max concurrency, for testing race conditions.Maybe this is overkill, I can drop some of this.