Skip to content

Conversation

@ahejlsberg
Copy link
Member

With this PR we display all meanings of a symbol in Quick Info. An (alias) prefix is displayed for non-local meanings that arise from import and export aliases.

image

Copilot AI review requested due to automatic review settings November 21, 2025 19:02
Copilot finished reviewing on behalf of ahejlsberg November 21, 2025 19:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances hover/quick info functionality to display all meanings (value, type, and namespace) of a symbol, with proper handling of import and export aliases. The (alias) prefix is displayed for non-local meanings that arise from imports and exports.

Key changes:

  • Refactored symbol display logic to recursively show all meanings of aliased symbols
  • Added proper nil checking for symbols before processing
  • Removed unused inConstructorContext function

@jakebailey
Copy link
Member

This fixes a massive number of fourslash tests that just need to be regenerated; unfortunately you'll probably need to do the goofy manual fix for getOccurrencesIfElseBroken if that isn't fixed by a plain npm run updatefailing.

I haven't had time to go rewrite these scripts to fix this yet (sorry...)

@jakebailey
Copy link
Member

Hm, it maybe it doesn't fix a bunch of tests. It seems like it's actually breaking something to do with the test fix detection. I am now looking into this.

@jakebailey
Copy link
Member

jakebailey commented Nov 21, 2025

Ah, the fourslash code is breaking because TestAliasMergingWithNamespace when unskipped causes a stack overflow. Probably should fix that lest a user hit it.

@ahejlsberg ahejlsberg enabled auto-merge November 21, 2025 21:33
@ahejlsberg ahejlsberg added this pull request to the merge queue Nov 21, 2025
Merged via the queue into main with commit 6ba0ed7 Nov 21, 2025
22 checks passed
@ahejlsberg ahejlsberg deleted the hover-all-meanings branch November 21, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants