-
Notifications
You must be signed in to change notification settings - Fork 744
Display all symbol meanings in quick info #2144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances hover/quick info functionality to display all meanings (value, type, and namespace) of a symbol, with proper handling of import and export aliases. The (alias) prefix is displayed for non-local meanings that arise from imports and exports.
Key changes:
- Refactored symbol display logic to recursively show all meanings of aliased symbols
- Added proper nil checking for symbols before processing
- Removed unused
inConstructorContextfunction
|
This fixes a massive number of fourslash tests that just need to be regenerated; unfortunately you'll probably need to do the goofy manual fix for I haven't had time to go rewrite these scripts to fix this yet (sorry...) |
|
Hm, it maybe it doesn't fix a bunch of tests. It seems like it's actually breaking something to do with the test fix detection. I am now looking into this. |
|
Ah, the fourslash code is breaking because |
With this PR we display all meanings of a symbol in Quick Info. An
(alias)prefix is displayed for non-local meanings that arise fromimportandexportaliases.