Skip to content

Color of placeholder text of git commit message does not respect setting #230056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
d-mahard opened this issue Sep 28, 2024 · 2 comments · May be fixed by #246983
Open

Color of placeholder text of git commit message does not respect setting #230056

d-mahard opened this issue Sep 28, 2024 · 2 comments · May be fixed by #246983
Assignees
@hediet
Labels
bug Issue identified by VS Code Team member as probable bug scm General SCM compound issues
Milestone
Backlog

Comments

@d-mahard
Copy link
Contributor

Does this issue occur when all extensions are disabled?: Yes

Version: 1.93.1 (user setup)
Commit: 38c31bc
Date: 2024-09-11T17:20:05.685Z
Electron: 30.4.0
ElectronBuildId: 10073054
Chromium: 124.0.6367.243
Node.js: 20.15.1
V8: 12.4.254.20-electron.0
OS: Windows_NT x64 10.0.22631

Steps to Reproduce:

  1. Pick any theme
  2. set "workbench.colorCustomizations": { "editor.placeholder.foreground": "#ff0000"}
  3. expected: placeholder text of git commit message should turn red (or to any color you set) - but actually it stays the default which is "editorGhostText.foreground". Changing the ghost text color indeed also changes this placeholder text color.

I checked using the developer tool that the placeholder text of git commit message is indeed controlled by editor.placeholder.foreground.

see screenshot below

(theme: default dark modern)

image

(theme: wine-bar-monokai)

image
@lszomoru lszomoru added scm General SCM compound issues bug Issue identified by VS Code Team member as probable bug labels Sep 30, 2024
@lszomoru lszomoru added this to the October 2024 milestone Sep 30, 2024
@lszomoru
Copy link
Member

@hediet, is this an issue with the editor placeholder? Thanks!

@lszomoru lszomoru modified the milestones: October 2024, November 2024 Oct 22, 2024
@lszomoru lszomoru modified the milestones: November 2024, Backlog Nov 30, 2024
@lszomoru lszomoru removed their assignment Dec 10, 2024
@d-mahard
Copy link
Contributor Author

@hediet @lszomoru May I take this one and create a PR?

d-mahard added a commit to d-mahard/vscode that referenced this issue Apr 19, 2025
@d-mahard
fix: color of placeholder text does not respect setting
a486f71 
microsoft#230056
@d-mahard d-mahard linked a pull request Apr 19, 2025 that will close this issue
Open
d-mahard added a commit to d-mahard/vscode that referenced this issue Apr 19, 2025
@d-mahard
fix: color of placeholder text does not respect setting
b426368 
microsoft#230056
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hediet hediet

Labels
bug Issue identified by VS Code Team member as probable bug scm General SCM compound issues
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

fix: color of placeholder text does not respect setting d-mahard/vscode
3 participants
@hediet @lszomoru @d-mahard