Skip to content

refactor(nls): use then for JSON parsing #247013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bytemain
Copy link
Contributor

In the original code, using await inside each readFile call within Promise.all made them execute sequentially, negating the parallel execution benefit of Promise.all. The refactored version uses .then to parse JSON after readFile promises resolve, enabling all operations in Promise.all to run truly in parallel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants