-
Notifications
You must be signed in to change notification settings - Fork 18
Graph-Kiota software requirements specifications #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
baywet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting all this together.
You'll see that I left a lot of comments that can roughly be divided in those categories:
- Comments to improve this first iteration
- Answers to questions you're asking, or precisions to let you know about discussions that happened
- Suggestions to move some of the content in the Kiota repo
but overall, great first draft!
| ``` | ||
| kiota.exe -d https://raw.githubusercontent.com/microsoftgraph/msgraph-metadata/master/openapi/v1.0/openapi.yaml --language typescript -o path\msgraph-sdk-typescript\src -c GraphServiceClient -n MicrosoftGraph | ||
| ``` | ||
| - GraphServiceClient generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I suggest adding a link to the parameters reference? https://github.com/microsoft/kiota/#parameters-reference
|
|
||
| ### Example of how we use the Kiota libraries: | ||
|
|
||
| 1. Clone the Kiota repo, build the project and navigate the path containing the `kiota.exe` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we refer to this documentation, and improve it if required? https://github.com/microsoft/kiota/#generating-sdks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are language specific pages here https://github.com/microsoft/kiota/tree/main/docs/requiredtools that show how to use the Kiota tooling. There dotnet one has an end to end experience. It would be great to do the same for JS/TS
Co-authored-by: Darrel <darrmi@microsoft.com> Co-authored-by: Vincent Biret <vibiret@microsoft.com>
…pdates Enrichment to Graph-Kiota software requirements specifications
Creating this PR to open a discussion and capture the specifications as we go along with the implementation of Graph and Kiota.
There are
Kiotafiles here which we can move after we have a concrete set of requirements and implementations. Till then let's maintain one place to capture the decisions we make.