Skip to content

Enrichment to Graph-Kiota software requirements specifications #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Enrichment to Graph-Kiota software requirements specifications #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions graph-kiota/graph-kiota.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ GraphCoreClient {
GraphServiceClient
```
class GraphServiceClient{
httpCoreInstance : HttpCore // From Kiota
requestAdapterInstance : RequestAdapter // From Kiota

UserRequestBuilder();
MailRequestBuilder();
Expand All @@ -62,6 +62,15 @@ This library contains the
- Authentication Providers
- Use the `IAuthenticationProvider` and authentication provider class from the Kiota abstractions.

- BaseRequest/IBaseRequest
- These classes/interfaces would be dropped as they are rendered redundant by the existence of `RequestInformation` from the Kiota core libraries and provide better support for conversion to native http request objects.
- Existing extensions/features/enrichments to the classes/interfaces would be moved to the `RequestInformation` through the graph core library.(e.g. one can use `BaseRequest` instances to create a batch request, now we would use `RequestInformation` instances)

- HttpProvider/IHttpProvider
- These classes/interfaces would be dropped as they are rendered redundant by the existence of `IRequestAdapter` from the Kiota core libraries and provide the necessary functionality to perform http requests

- Response Handler
- Any existing/needed response handlers to now implement the `IResponseHandler` (or equivalent) from kiota core libraries

#### Graph Service library specifications

Expand All @@ -75,7 +84,7 @@ This library contains the
- Import middlewares from Kiota core library
- How to add graph specific checks in the middleware. Example: The JS SDK checks if the url is a Graph url or a custom host passed by the user before appending telemetry headers or auth headers. If not, the headers are removed.

- AuthHandler - Kiota core
- AuthHandler - none - This avoids having to configure both the middleware and the provider and the authentication provider implementations are available across any http client
- RetryHandler - Kiota core
- RedirectHandler - Kiota core
- CompressionHandler - Kiota core
Expand Down