File tree Expand file tree Collapse file tree 3 files changed +23
-19
lines changed
backend/analytics_server/mhq Expand file tree Collapse file tree 3 files changed +23
-19
lines changed Original file line number Diff line number Diff line change @@ -168,6 +168,7 @@ def get_team_lead_time_trends(
168168 for week , average_lead_time_metrics in weekly_lead_time_metrics_avg_map .items ()
169169 }
170170
171+
171172@app .route ("/teams/<team_id>/prs/merged_without_review" , methods = {"GET" })
172173@queryschema (
173174 Schema (
@@ -177,16 +178,11 @@ def get_team_lead_time_trends(
177178 }
178179 ),
179180)
180- def merged_without_review (
181- team_id : str ,
182- from_time : datetime ,
183- to_time : datetime
184- ):
181+ def merged_without_review (team_id : str , from_time : datetime , to_time : datetime ):
185182 query_validator = get_query_validator ()
186183 team : Team = query_validator .team_validator (team_id )
187184 interval : Interval = query_validator .interval_validator (from_time , to_time )
188185 pr_analytics = get_pr_analytics_service ()
189- result = pr_analytics .get_prs_merged_without_review (team .id ,interval )
186+ result = pr_analytics .get_prs_merged_without_review (team .id , interval )
190187 prs_map = [pr .id for pr in result ]
191- return {'PrsWithoutReviewMerged' : prs_map }
192-
188+ return {"PrsWithoutReviewMerged" : prs_map }
Original file line number Diff line number Diff line change 22from mhq .store .repos .code import CodeRepoService
33
44
5- from typing import List ,Optional
5+ from typing import List , Optional
66from mhq .utils .time import Interval
77
88
@@ -12,9 +12,11 @@ def __init__(self, code_repo_service: CodeRepoService):
1212
1313 def get_prs_by_ids (self , pr_ids : List [str ]) -> List [PullRequest ]:
1414 return self .code_repo_service .get_prs_by_ids (pr_ids )
15-
16- def get_prs_merged_without_review (self ,team_id :str ,interval :Interval ) -> List [PullRequest ]:
17- return self .code_repo_service .get_prs_merged_without_review (team_id ,interval )
15+
16+ def get_prs_merged_without_review (
17+ self , team_id : str , interval : Interval
18+ ) -> List [PullRequest ]:
19+ return self .code_repo_service .get_prs_merged_without_review (team_id , interval )
1820
1921 def get_team_repos (self , team_id : str ) -> List [OrgRepo ]:
2022 return self .code_repo_service .get_team_repos (team_id )
Original file line number Diff line number Diff line change @@ -366,16 +366,22 @@ def get_team_repos(self, team_id) -> List[OrgRepo]:
366366
367367 team_repo_ids = [tr .org_repo_id for tr in team_repos ]
368368 return self .get_repos_by_ids (team_repo_ids )
369-
369+
370370 @rollback_on_exc
371- def get_prs_merged_without_review (self ,team_id ,interval ) -> List [PullRequest ]:
371+ def get_prs_merged_without_review (self , team_id , interval ) -> List [PullRequest ]:
372372 AllOrg = self .get_team_repos (team_id )
373373 AllOrg_ids = [tr .id for tr in AllOrg ]
374- return (self ._db .session .query (PullRequest )
375- .filter (PullRequest .repo_id .in_ (AllOrg_ids ))
376- .filter (PullRequest .merge_time == None )
377- .filter (PullRequest .created_in_db_at .between (interval .from_time ,interval .to_time ))
378- .all ())
374+ return (
375+ self ._db .session .query (PullRequest )
376+ .filter (PullRequest .repo_id .in_ (AllOrg_ids ))
377+ .filter (PullRequest .merge_time == None )
378+ .filter (
379+ PullRequest .created_in_db_at .between (
380+ interval .from_time , interval .to_time
381+ )
382+ )
383+ .all ()
384+ )
379385
380386 @rollback_on_exc
381387 def get_team_repos_by_team_id (self , team_id : str ) -> List [TeamRepos ]:
You can’t perform that action at this time.
0 commit comments