Optimised the Bussiness Logic function and moved repo_ids to PullRequestAnalyticsService

Author: RISHIKESHk07

backend/analytics_server/mhq/api/resources/code_resouces.py

@@ -172,8 +172,3 @@ def adapt_team_repos(team_repos: List[TeamRepos]) -> List[Dict[str, any]]:
         }
         for team_repo in team_repos
     ]
-
-def get_non_paginated_merged_without_review(prs: List[PullRequest]) -> List[Dict[str,any]]:
-    return {
-        "data": []
-    }

backend/analytics_server/mhq/service/code/pr_analytics.py

@@ -16,8 +16,11 @@ def get_prs_by_ids(self, pr_ids: List[str]) -> List[PullRequest]:
     def get_prs_merged_without_review(
         self, team_id: str, interval: Interval, pr_filter: dict
     ) -> List[PullRequest]:
+        team_repos = self.code_repo_service.get_team_repos(team_id)
+        repo_ids = [team_repo.id for team_repo in team_repos]
+
         return self.code_repo_service.get_prs_merged_without_review(
-            team_id, interval, pr_filter
+            repo_ids, interval, pr_filter
         )
 
     def get_team_repos(self, team_id: str) -> List[OrgRepo]:

backend/analytics_server/mhq/store/repos/code.py

@@ -369,26 +369,15 @@ def get_team_repos(self, team_id) -> List[OrgRepo]:
 
     @rollback_on_exc
     def get_prs_merged_without_review(
-        self, team_id: str, interval: Interval, pr_filter: PRFilter = None
+        self, repo_ids: List[str], interval: Interval, pr_filter: PRFilter = None
     ) -> List[PullRequest]:
-        AllOrg = self.get_team_repos(team_id)
-        AllOrg_ids = [tr.id for tr in AllOrg]
         query = (
             self._db.session.query(PullRequest)
-            .filter(PullRequest.repo_id.in_(AllOrg_ids))
+            .filter(PullRequest.repo_id.in_(repo_ids))
             .filter(PullRequest.state == PullRequestState.MERGED)
-            .filter(PullRequest.merge_time == None)
-            .filter(
-                or_(
-                    PullRequest.created_at.between(
-                        interval.from_time, interval.to_time
-                    ),
-                    PullRequest.updated_at.between(
-                        interval.from_time, interval.to_time
-                    ),
-                )
-            )
+            .filter(PullRequest.merge_time.is_(None))
         )
+        query = self._filter_prs_merged_in_interval(query, interval)
         query = self._filter_prs(query, pr_filter)
 
         return query.all()