Skip to content

Commit a6838a2

Browse files
Do not allow event names with hyphens in them
Fixes #36
1 parent a3ae2a9 commit a6838a2

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

socketio/server.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,8 @@ def message_handler(sid, msg):
138138
client's acknowledgement callback function if it exists. The
139139
``'disconnect'`` handler does not take a second argument.
140140
"""
141+
if '-' in event:
142+
raise ValueError('event names cannot contain hypens')
141143
namespace = namespace or '/'
142144

143145
def set_handler(handler):

tests/test_server.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,10 @@ def bar():
4545
self.assertEqual(s.handlers['/']['disconnect'], bar)
4646
self.assertEqual(s.handlers['/foo']['disconnect'], bar)
4747

48+
def test_on_bad_event_name(self, eio):
49+
s = server.Server()
50+
self.assertRaises(ValueError, s.on, 'two-words')
51+
4852
def test_emit(self, eio):
4953
mgr = mock.MagicMock()
5054
s = server.Server(client_manager=mgr)

0 commit comments

Comments
 (0)